Repository navigation
fix(cli): send attach time skipped while sync or the module was off (TM-963) - #916
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipped attach time was closed for good in sent.jsonl. Now a skipped record is retried on every flush while sync and the workspace module are on, so it is sent when either turns back on; records older than the existing EXPIRE_S window (29 days) become expired instead of being back-sent. While off, skipped records are not re-marked each flush (no log growth). Cost: a workspace with skipped records gets one enabled() call per flush until the records expire or are sent. Three tests added.