Annotate Choice.disabled as str or bool #467
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Choice.disabledis annotated as an optionalstrbut can also be abool:questionary/questionary/prompts/common.py
Lines 434 to 438 in dc46610
Partially related to #251 (comment)
How did you solve it?
This PR changes the type of
Choice.disabledand related annotations toOptional[Union[str, bool]].Checklist