Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htmlq: add page #15625

Merged
merged 4 commits into from
Feb 7, 2025
Merged

htmlq: add page #15625

merged 4 commits into from
Feb 7, 2025

Conversation

wong-justin
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 0.4.0

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 28, 2025
spageektti
spageektti reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you so much for your contribution!

pages/common/htmlq.md Outdated Show resolved Hide resolved
pages/common/htmlq.md Outdated Show resolved Hide resolved
pages/common/htmlq.md Outdated Show resolved Hide resolved
pages/common/htmlq.md Outdated Show resolved Hide resolved
pages/common/htmlq.md Outdated Show resolved Hide resolved
pages/common/htmlq.md Outdated Show resolved Hide resolved
@wong-justin @spageektti
Apply suggestions from code review
927ef37 
Co-authored-by: Wiktor Perskawiec <[email protected]>
gutjuri
gutjuri reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have one minor suggestion

pages/common/htmlq.md Outdated Show resolved Hide resolved
Managor
Managor reviewed Feb 2, 2025
View reviewed changes
pages/common/htmlq.md Outdated Show resolved Hide resolved
@Managor Managor merged commit 549ba9c into tldr-pages:main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti left review comments

@gutjuri gutjuri gutjuri approved these changes

@Managor Managor Managor approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wong-justin @gutjuri @Managor @spageektti