Configurable tools #140
Configurable tools #140
Conversation
|
Not ready yet, PR opened to be able to clarify a few things |
|
Q1: What are you doing with that 'includes' parameter? |
… YAML configuration. All chef, vagrant and atom extras are conditional on the presence of the tool in the configuration
|
That Appveyor build is going to block forever because it's asking for the git name and email |
|
Torben I need your input here, there's a few things that do not work due to environment scripts:
On the other hand I've restructured most of the Rakefile so that we can use it as a basis for all devpacks and handle exceptions (like the double unpack for Chef). Basically I broke the kitchen and took home the oven to bake my own cookies. |
| def target_dir | ||
| ddir=ENV["TARGET_DIR"] | ||
| ddir||=File.join(base_dir,"target") | ||
| File.expand_path(ddir) |
There was a problem hiding this comment.
how about File.expand_path(ENV["TARGET_DIR"] || File.join(base_dir, "target") instead?
for my own taste a bit more readable as a one-liner, but not being picky here
| #chefdk install package contains a zip file | ||
| extra_pkg="#{target_dir}/chefdk/opscode/chefdk.zip" | ||
| tgt_dir="#{target_dir}/chefdk/opscode/" | ||
| unpack(extra_pkg, tgt_dir, includes = []) |
There was a problem hiding this comment.
need the extra_pkg and tgt_dir vars here? I'd rather inline them here...
| end | ||
|
|
||
| desc 'downloads required resources and builds the devpack binary' | ||
| task :build => :clean do | ||
| tools_config=YAML.load(File.read("#{base_dir}/config/tools.yaml")) |
| move_chefdk | ||
| fix_chefdk | ||
| download_tools(tools_config) | ||
| if tools_config.keys.include?("chefdk") |
There was a problem hiding this comment.
wonder if we could make this a bit more generic and pluggable. not necessarily for bills-kitchen here, but if we want to use that as a minimal template for future devpacks
There was a problem hiding this comment.
All the ifs in the :build task I mean...
| File.write(file, File.read(file).gsub('@"C:\opscode\chefdk\embedded\bin\ruby.exe" "%~dpn0" %*', '@"%~dp0\..\..\..\..\..\bin\ruby.exe" "%~dpn0" %*')) | ||
| end | ||
| end | ||
|
|
||
| def install_knife_plugins | ||
| def install_knife_plugins tool_config |
| fail "knife plugin installation failed" unless system(command) | ||
| end | ||
| end | ||
|
|
||
| def install_vagrant_plugins | ||
| def install_vagrant_plugins tool_config |
| fail "vagrant plugin installation failed" unless system(command) | ||
| end | ||
| end | ||
|
|
||
| def install_atom_plugins | ||
| def install_atom_plugins tool_config |
both the build_dir and cache_dir were nested under target_dir originally. restoring that for now...
(earlier this was cdk, hope it won't hit the max path length issue with chef_dk...)
|
@damphyr while I believe we could get this to work / pass the appveyor build again, I'm not sure what to do with it. Instead of doing something half-assed, I'd rather focus on making https://github.com/Zuehlke/z-devpack reusable / modular enough (see Zuehlke/z-devpack#1) so it can be the new basis for bills-kitchen. What do you think? |
|
What I think is : https://github.com/Zuehlke/z-devpack :) |
|
Do we scrap this or should I bring it up to date? |
|
I should probably add some large banner stating that this is unmaintained (ever since I switched to macOS about 1.5 years ago...) I'm currently maintaining https://github.com/tknerr/linus-kitchen/ instead, which is a Linux Developer VM variant with the same intent / goal as Bill's Kitchen. So yes, I'm in favor of ditching this, unless someone wants to continue to maintain it |
Pulls out the tool configuration in a YAML file under config.
Also makes all constant values (CACHE_DIR, ZIP_EXE etc.) overridable through environment variables (which you can use on the rake command line)
Updates all software to the latest versions.