Implement signer.authorize for EIP-7702 transactions #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a44cbea:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for EIP-7702 authorization signing by exposing a new signAuthorization method on TurnkeySigner, upgrades ethers to v6.14.4 (and related dev deps), and updates unit tests to cover the new flow.
- Bump
ethers, Hardhat, and network helper versions - Implement
signAuthorizationonTurnkeySignerand refineserializeSignature - Expand
index-test.tswith EIP-7702 authorization tests
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ethers/src/index.ts | Added signAuthorization method, error wrapping, and signature serialization checks |
| packages/ethers/src/tests/index-test.ts | Updated imports and added an EIP-7702 authorization test |
| packages/ethers/package.json | Upgraded ethers, Hardhat, and helper versions |
| .changeset/gold-glasses-reflect.md | New changeset for the minor feature release |
Comments suppressed due to low confidence (3)
packages/ethers/src/index.ts:324
- The method is named
signAuthorizationbut the Ethers standard and PR title refer toauthorize; consider renaming (or aliasing) this method toauthorizefor consistency with Ethers.Signer.
async signAuthorization(
packages/ethers/src/tests/index-test.ts:462
- The new positive test covers the happy path, but there are no negative tests for invalid inputs (bad address, bad chainId, bad code, chainId mismatch). Consider adding tests that assert your error branches.
testCase("it signs EIP-7702 authorization", async () => {
packages/ethers/src/index.ts:324
- [nitpick] Add a JSDoc comment for
signAuthorizationdescribing its parameters (address,chainId,nonce,code) and return type (Authorization) so consumers know how to use it.
async signAuthorization(
Comment on lines
+425
to
+431
| ethers.hashAuthorization({ | ||
| address: normalizedAddress, | ||
| chainId: normalizedChainId, | ||
| nonce: normalizedNonce, | ||
| code, | ||
| } as ethers.AuthorizationRequest); | ||
|
|
There was a problem hiding this comment.
The return value of ethers.hashAuthorization(...) is not used; remove this call or capture its result if it’s intended for verification or logging.
Suggested change
| ethers.hashAuthorization({ | |
| address: normalizedAddress, | |
| chainId: normalizedChainId, | |
| nonce: normalizedNonce, | |
| code, | |
| } as ethers.AuthorizationRequest); | |
| const authorizationHash = ethers.hashAuthorization({ | |
| address: normalizedAddress, | |
| chainId: normalizedChainId, | |
| nonce: normalizedNonce, | |
| code, | |
| } as ethers.AuthorizationRequest); | |
| console.debug(`Authorization hash computed: ${authorizationHash}`); |
Comment on lines
+356
to
+373
| // testCase("it signs authorization (EIP-712 permit style)", async () => { | ||
| // // Define the EIP-712 domain for EIP-7702 | ||
| // const domain = { | ||
| // name: "EIP7702Authorization", | ||
| // version: "1", | ||
| // chainId: chainId, | ||
| // verifyingContract: "0x0000000000000000000000000000000000000000", | ||
| // }; | ||
|
|
||
| // // Define the EIP-7702 AuthorizationRequest | ||
| // const authRequest: ethers.AuthorizationRequest = { | ||
| // address: signingConfig.expectedEthAddress, | ||
| // chainId: chainId, | ||
| // nonce: 0, | ||
| // }; | ||
|
|
||
| // try { | ||
| // // Sign the authorization |
There was a problem hiding this comment.
[nitpick] There’s a large block of commented-out test code above the real EIP-7702 test; remove it to keep the test file clean and focused.
Suggested change
| // testCase("it signs authorization (EIP-712 permit style)", async () => { | |
| // // Define the EIP-712 domain for EIP-7702 | |
| // const domain = { | |
| // name: "EIP7702Authorization", | |
| // version: "1", | |
| // chainId: chainId, | |
| // verifyingContract: "0x0000000000000000000000000000000000000000", | |
| // }; | |
| // // Define the EIP-7702 AuthorizationRequest | |
| // const authRequest: ethers.AuthorizationRequest = { | |
| // address: signingConfig.expectedEthAddress, | |
| // chainId: chainId, | |
| // nonce: 0, | |
| // }; | |
| // try { | |
| // // Sign the authorization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In order to support EIP-7702 transactions via
@turnkey/etherswe need to exposesigner.authorize()v6.14.4to ensure latest support for EIP-7702signAuthorization()function from@turnkey/etherspackageLinear Ref
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.