fix: targets gc

tkestack · Jun 17, 2022 · b7451df · b7451df
1 parent 2660eb4
commit b7451df
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,3 +1,4 @@
 FROM ubuntu:latest
+RUN apt update && apt install -y curl
 COPY kvass /kvass
 ENTRYPOINT ["/kvass"]
diff --git a/pkg/coordinator/rebalance.go b/pkg/coordinator/rebalance.go
@@ -214,8 +214,7 @@ func (c *Coordinator) gcTargets(changeAbleShards []*shardInfo, active map[uint64
 					// is in_transfer state and had been scraped by other shard
 					if (tar.TargetState == target.StateInTransfer && st.TargetState == target.StateNormal) ||
 						// is in normal state and had been scraped by other shard with lower head series
-						(tar.TargetState == target.StateNormal &&
-							st.TargetState == target.StateNormal &&
+						(tar.TargetState == st.TargetState &&
 							other.runtime.HeadSeries < s.runtime.HeadSeries) {
 						delete(s.scraping, h)
 						break