Skip to content

Improve SSAFile type annotations #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RafaelMuijsert
Copy link

This patch refactors type annotations in ssafile.py to fit modern PEP standards.

Furthermore, moving type hints to class-level annotations helps basedpyright deduce types, which it was previously not able to do.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (a9ef790) to head (43b7d09).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   92.20%   92.22%   +0.02%     
==========================================
  Files          40       40              
  Lines        2962     2970       +8     
  Branches      301      301              
==========================================
+ Hits         2731     2739       +8     
  Misses        151      151              
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant