Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, total Rust noobie here; please assume the worst.
Does it make sense to add
#![no_std]
to this lib? Adding this doesn't seem to make any tests in this lib to fail, and there seems to be previous discussions in this repo suggesting thatno_std
is a goal.The reason I ask is because I'm getting the following error in a downstream dep, Burn:
Cloning
constrandom
to my local machine, updating Burn'sCargo.toml
toand running the failing CI's command (
cargo build -p burn --no-default-features --target wasm32-unknown-unknown --color=always
) works on my local machine (when previously I could replicate the failure locally).