Custom routes registered first, so collection are not overriden by the show default route#9
Open
standuprey wants to merge 2 commits into
Open
Custom routes registered first, so collection are not overriden by the show default route#9standuprey wants to merge 2 commits into
standuprey wants to merge 2 commits into
Conversation
added 2 commits
October 14, 2013 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the 'search' action was registered after the default mapping, so comments/search was redirected to the comment's show action with search as id, and never reached the 'search' custom action.
This pull request makes sure that the custom actions are registered first and thus not caught be the default mapping
It also corrects a bug that made the "before" option not working on custom actions