Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not wrap the :headers / :xhr attributes within :params #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not wrap the :headers / :xhr attributes within :params #14

wants to merge 2 commits into from

Conversation

vongruenigen
Copy link

This PR fixes issue #13: We should wrap the :headers hash within :params as :headers can be used to set HTTP headers when doing HTTP request in rails tests (see here).

@vongruenigen
Copy link
Author

As explained in the issue #13, the :xhr key has the same problem as :headers. My last commit fixed this as well.

@vongruenigen vongruenigen changed the title Fixes #13: Do not wrap the :headers hash within :params Do not wrap the :headers / :xhr attributes within :params May 14, 2019
joel added a commit to joel/rails5-spec-converter that referenced this pull request Sep 30, 2021
@joel
Do not wrap the :headers / :xhr attributes within :params
db400d8 
tjgrathwell#14
https://github.com/vongruenigen
@vongruenigen
@joel joel mentioned this pull request Sep 30, 2021
Merged
joel added a commit to joel/rails5-spec-converter that referenced this pull request Sep 30, 2021
@joel
Do not wrap the :headers / :xhr attributes within :params (#6)
0a27bdd 
tjgrathwell#14
https://github.com/vongruenigen
@vongruenigen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vongruenigen