Exempt lifecycle and construction methods from test gaps (#854 with main merged) - #867
Merged
Conversation
setUp, tearDown, constructors and their xUnit/unittest variants are exercised implicitly by every test that touches their class. Listing them as test gaps inflates the gap count and pushes noise into the Untested summary, which erodes trust in the panel for real gaps. Partial fix; the container-resolution linkage itself is tracked in issue 850 and in issue 851. Part of #850
Keep both tests at the shared anchor in tests/test_changes.py: the relative-path flows regression from #852 and the lifecycle exemption regression from this branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012fHfGDiZedoxjpKzanHri3
code-review-graph reviewOverall risk: 0.30 (LOW) — 3 changed function(s)/class(es), 0 affected flow(s), 1 test gap(s) Risk-scored changes
Test gaps
Token savings: this graph-backed report used ~12,473 fewer tokens (~95%) than reading every changed file in full (estimated, chars/4 approximation). Powered by code-review-graph — local-first analysis; no code leaves the CI runner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #854 (author asemraza) with current main merged in and the test-anchor conflict against #852 resolved by keeping both tests. Validated locally: tests/test_changes.py 38 passed, full suite 2456 passed, ruff and mypy clean.
Opened because the source branch needs a conflict resolution that cannot be pushed to the fork from here. Merging this lands the original commits unchanged, so #854 will show as merged.
Part of #850.