fix(mcp): isolate stdio parsing from process pools#648
Merged
Conversation
code-review-graph reviewOverall risk: 0.60 (MEDIUM) — 14 changed function(s)/class(es), 0 affected flow(s), 8 test gap(s) Risk-scored changes
Test gaps
Token savings: this graph-backed report used ~51,552 fewer tokens (~94%) than reading every changed file in full (estimated, chars/4 approximation). Powered by code-review-graph — local-first analysis; no code leaves the CI runner. |
tirth8205
force-pushed
the
codex/port-mcp-stdio-executor
branch
from
July 17, 2026 17:29
ea24c6f to
fd320ad
Compare
Use threads only while FastMCP runs over stdio, preserving the process-pool default for ordinary Unix CLI and CI automation. Add a real parallel-build JSON-RPC shutdown regression. Reconciles PR #615. Co-authored-by: Minxi Hou <houminxi@gmail.com>
tirth8205
force-pushed
the
codex/port-mcp-stdio-executor
branch
from
July 17, 2026 19:45
fd320ad to
dc56741
Compare
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safe current-main replacement for #615, retaining Minxi Hou as co-author.
Source reconciliation
The source head no longer contains its claimed production executor change. Its added test invokes a module without the real entry point, forces thread mode, supplies too few files to enter the parallel path, detects descendants only after the parent exits, uses pgrep on Windows, and accepts crashes or nonzero exit codes.
This replacement uses the real
python -m code_review_graph serveentry point and a JSON-RPC initialize plus full-build tool call over stdio. It builds 10 files so parallel parsing is entered, verifies the complete response and database, closes stdin, and requires a clean zero exit.Overlap resolution
The branch is based exactly on main 4f9f035. Its incremental.py changes auto-merged with #650 NUL-path discovery. The only textual conflict was CHANGELOG ordering; both independent entries were retained.
Verification