feat(query): surface bounded transitive test coverage#636
Merged
Conversation
Port the safe tests_for behavior from PR #334 while preserving sanitized node responses, explicit direct/indirect markers, bounded traversal, and explicit ambiguity. Co-authored-by: Gideon Zenz <91069374+gzenz@users.noreply.github.com>
code-review-graph reviewOverall risk: 0.60 (MEDIUM) — 6 changed function(s)/class(es), 0 affected flow(s), 3 test gap(s) Risk-scored changes
Test gaps
Token savings: this graph-backed report used ~21,731 fewer tokens (~93%) than reading every changed file in full (estimated, chars/4 approximation). Powered by code-review-graph — local-first analysis; no code leaves the CI runner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- ports only the safe tests_for behavior from stale cumulative PR #334\n- uses the existing bounded GraphStore transitive lookup for direct and one-hop test coverage\n- rebuilds every result through node_to_dict so names and qualified names remain sanitized and the established full node schema is preserved\n- adds an explicit indirect boolean to standard and minimal results\n- keeps ambiguous bare symbols explicit; it does not carry #334's unsafe silent production-node preference\n- caller/callee/inheritor deduplication was already present on main and is not duplicated\n\n## Attribution\nSource: #334 by Gideon Zenz, reviewed commit c5eb771. The port commit has a Co-authored-by trailer for Gideon Zenz.\n\n## Verification\n- TDD red: direct result lacked indirect; one-hop test was absent; ambiguity guard stayed green\n- focused query + graph modules: 122 passed\n- current-main full suite after rebase: 1489 passed, 1 skipped, 2 xpassed\n- changed-file Ruff and git diff check passed\n- graph rebuilt without errors; no affected execution flows\n\nThis replaces only the viable current-main delta and excludes the stale stacked history and unsafe ambiguity behavior.