re-enable ci #10
Open
re-enable ci #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daminetreg
reviewed
May 15, 2025
tipi/vault.hpp
Outdated
| auto tmp = std::string(It(std::begin(val)), It(std::end(val))); | ||
| return tmp.append((3 - val.size() % 3) % 3, '='); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why would we not use xxhr ?
There was a problem hiding this comment.
because boringssl is really complicated to support with wasm-asmjs as target
There was a problem hiding this comment.
xxhr doesnt' need boringssl in emscripten builds, it might be wrongfully stated with the current deps file but there is a custom backend of xxhr for asmjs
There was a problem hiding this comment.
I will change that nd try to keep xxhr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pr is to update the ci in order to be more confident in our next modification.