Support mvsc on remote build #12
Conversation
There was a problem hiding this comment.
For me this one is clearly non-mergeable in this state. The only part that's clean to me (at first sight) is the change to the macos pkr file.
I'm quite sure the solution you hacked here is not what we should do. I'd rather add some sort of environment aliasing that the cli has to understand (as in ìf there's no my-targert.pkr.js (file|folder) look for a my-target.pkr.js.alias file which can point to another environment and zip up that one)`
@daminetreg what's your take on that one?
build_engine_mapping.json
Outdated
| @@ -1,4 +1,6 @@ | |||
| { | |||
| "vs-15-2017-win64-cxx17" : "Visual Studio 15 2017 Win64", | |||
| "vs-16-2019-win64-cxx17" : "Visual Studio 16 2019" | |||
| "vs-16-2019-win64-cxx17" : "Visual Studio 16 2019", | |||
| "windows-vs-16-2019-win64-cxx17" : "Visual Studio 16 2019" | |||
There was a problem hiding this comment.
You just kind-of made just half the work here.
If we're touching that one anyway we should make the due dilligence to list all of the targets that actually need the generator properly set to Visual Studio xx 20yy . Espeacially as you potentially made another addition down below which isn't working (the cxx11 version defined windows-vs-16-2019-win64.cmake namely....)
windows-vs-16-2019-win64-cxx17.cmake
Outdated
| # Copyright (c) 2015-2017, Ruslan Baratov | ||
| # All rights reserved. | ||
|
|
||
| if(DEFINED POLLY_VS_16_2019_WIN64_CXX17_CMAKE_) | ||
| return() | ||
| else() | ||
| set(POLLY_VS_16_2019_WIN64_CXX17_CMAKE_ 1) | ||
| endif() | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/utilities/polly_init.cmake") | ||
|
|
||
| polly_init( | ||
| "Visual Studio 16 2019 Win64 / C++17" | ||
| "Visual Studio 16 2019" | ||
| ) | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/utilities/polly_common.cmake") | ||
| include("${CMAKE_CURRENT_LIST_DIR}/flags/vs-cxx17.cmake") |
There was a problem hiding this comment.
vs-16-2019-win64-cxx17.cmake should have used CMake's include() rather than making that copy imho
windows-vs-16-2019-win64.cmake
Outdated
| # Copyright (c) 2015-2017, Ruslan Baratov | ||
| # All rights reserved. | ||
|
|
||
| if(DEFINED POLLY_VS_16_2019_WIN64_CMAKE_) | ||
| return() | ||
| else() | ||
| set(POLLY_VS_16_2019_WIN64_CMAKE_ 1) | ||
| endif() | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/utilities/polly_init.cmake") | ||
|
|
||
| polly_init( | ||
| "Visual Studio 16 2019" | ||
| "Visual Studio 16 2019" | ||
| ) | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/utilities/polly_common.cmake") |
| { | ||
| "type": "powershell", | ||
| "inline": [ | ||
| "Invoke-WebRequest -Uri 'https://bootstrap.pypa.io/get-pip.py' -OutFile 'get-pip.py'", | ||
| "tipi run 'python get-pip.py'" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
And 💥 we just introduced a bugfix in a copy which happens to be lacking in the other one.... Which is why this copy is a really bad idea.
This pr is intended to allow remote compiling with msvc