[codex] expose wallet email verification in SDK#26
Conversation
|
@senamakel is attempting to deploy a commit to the Vezures Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
More reviews will be available in 7 minutes and 19 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10dcac87b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (value.harnessKey || !harnessKey) { | ||
| return value; | ||
| } | ||
| return { ...value, harnessKey }; |
There was a problem hiding this comment.
Do not mutate already-signed profile payloads
When callers pass a precomputed signature while the client has a default harnessKey, this helper adds a new signed field before the !signature guard skips re-signing. The backend verifies the signature over the body it receives, so the signature no longer matches unless the caller knew to include exactly this harness key; preserve signed payloads or only apply the default when signing locally.
Useful? React with 👍 / 👎.
| }); | ||
|
|
||
| const identity = await client.registry.register({ ...request, payment }); | ||
| await recordHarness(client, signer); |
There was a problem hiding this comment.
Do not fail paid registrations on harness recording
In the paid registration path, registry.register has already returned success and the x402 payment has been accepted before this extra profile update runs. If /users/{id}/profile is unavailable or rejects the harness update, buyDomain now throws even though the handle and payment succeeded, which can make agents retry/pay again or report a false failure; treat harness recording as best-effort or return the registration result.
Useful? React with 👍 / 👎.
What changed
Validation
Notes