Skip to content

chore(tinyagents): align v2.1 and reconcile migration plan#5130

Merged
senamakel merged 8 commits into
tinyhumansai:mainfrom
senamakel:feat/tinyagents-migration-2026-07-22
Jul 23, 2026
Merged

chore(tinyagents): align v2.1 and reconcile migration plan#5130
senamakel merged 8 commits into
tinyhumansai:mainfrom
senamakel:feat/tinyagents-migration-2026-07-22

Conversation

@senamakel

@senamakel senamakel commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Align the vendored TinyAgents gitlink and manifest at v2.1.0.
  • Align TinyFlows with TinyAgents 2.1 so Cargo does not resolve a second 1.9 trait universe.
  • Reconcile the migration audit, drift ledger, deletion ledger, stale plan banners, and dangling documentation links.
  • Fix the stale flow-resume finalization call that prevented current upstream/main from compiling.

Problem

  • OpenHuman required TinyAgents 2.1 while the vendored manifest still reported 1.9, the ledger reported 1.8, and TinyFlows retained a 1.x dependency range.
  • The migration documents contained stale status and references to files that do not exist.
  • A recently expanded finish_flow_run_row signature left one resume failure path uncompilable.

Solution

  • Fast-forward the TinyAgents gitlink to the released v2.1.0 tag and remove an unused historical fork-source patch.
  • Pin TinyFlows to 2.1 through chore(deps): align TinyAgents with v2.1 tinyflows#14 and record the cross-crate constraint in the active plan.
  • Establish the 2026-07-22 audit as the active plan and add the deletion ledger used by subsequent work packages.
  • Pass flow_id through the compatibility-rejection finalization path.

Submission Checklist

  • N/A: no new feature behavior; the flow call-site regression is compiler-covered and the dependency changes are covered by crate/host checks.
  • N/A: documentation, gitlinks, manifests, and a compile-only call-site fix do not add uncovered behavior; CI still enforces the diff gate.
  • N/A: no feature row was added, removed, or renamed.
  • N/A: no affected feature IDs.
  • No new external network dependencies introduced.
  • N/A: no release-cut surface changed.
  • N/A: no issue is being auto-closed by this housekeeping slice.

Impact

  • No frontend or user-visible behavior change.
  • The host and TinyFlows now share the vendored TinyAgents 2.1 model/tool trait identity; v2.1 adds BarrierRelief for later migration work.
  • Follow-on migration deletions are tracked explicitly instead of relying on phantom documents.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: feat/tinyagents-migration-2026-07-22
  • Commit SHA: d4df050fe

Validation Run

  • N/A: no frontend files; Prettier is unavailable in this fresh worktree because dependencies are not installed.
  • N/A: no TypeScript files changed.
  • Focused tests: TinyAgents cargo test --all-features (1,200 unit tests plus integration/doc tests); TinyFlows cargo check --locked.
  • Rust fmt/check: both Cargo fmt checks; root GGML_NATIVE=OFF cargo check; slim --no-default-features --features tokenjuice-treesitter check.
  • Tauri fmt passed; Tauri check reached CEF and is delegated to GitHub Actions due to the local CMake blocker below.

Validation Blocked

  • command: GGML_NATIVE=OFF cargo check --manifest-path app/src-tauri/Cargo.toml
  • error: local CMake 3.19.1; CEF requires CMake 3.21 or newer.
  • impact: no code diagnostic was emitted before CEF setup stopped; GitHub Actions supplies the authoritative app-world check.

Behavior Changes

  • Intended behavior change: dependency/version metadata and migration tracking become truthful; rejected flow resumes persist the correct flow id.
  • User-visible effect: none.

Parity Contract

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none.
  • Canonical PR: this PR.
  • Resolution (closed/superseded/updated): N/A.

Summary by CodeRabbit

  • Documentation

    • Added a consolidated, current migration plan with work packages, milestones, risks, and module dispositions.
    • Updated migration status records, phase gates, deletion tracking, and parity requirements.
    • Marked superseded planning documents as historical and redirected references to current guidance.
    • Updated provider configuration documentation and related migration references.
  • Bug Fixes

    • Updated a security regression test to use the current tool setup while preserving cross-profile write protections.
  • Chores

    • Refreshed internal project references and supporting tooling metadata.

@senamakel
senamakel requested a review from a team July 22, 2026 12:48
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This change consolidates TinyAgents migration planning, updates drift and historical status documentation, redirects host references, adjusts a NodeExecTool test constructor call, removes a local Cargo patch override, and updates the vendored TinyFlows revision.

Changes

TinyAgents migration alignment

Layer / File(s) Summary
Current migration plan and deletion tracking
docs/tinyagents-migration-plan-2026-07-22.md, docs/tinyagents-full-migration-plan/99-deletion-ledger.md
Adds the consolidated migration plan and deletion ledger with version constraints, host audits, work packages, exit criteria, and deletion status.
Migration status and historical plan alignment
docs/tinyagents-drift-ledger.md, docs/tinyagents-full-migration-plan/C4-journal-progress-parity-plan.md, docs/tinyagents-inference-migration-plan.md, docs/tinyagents-phase3-router-registry-design.md, docs/tinyagents-port-plan.md
Updates migration anchors, completion markers, parity gates, authoritative references, and superseded-plan status.
Host documentation and test references
src/openhuman/agent/..., src/openhuman/inference/README.md, src/openhuman/tinyagents/subagent_graph.rs, src/openhuman/tools/impl/system/node_exec.rs
Redirects documentation references and updates the regression test to pass the current NodeExecTool::new(...) arguments.
Dependency resolution and vendored TinyFlows update
app/src-tauri/Cargo.toml, vendor/tinyflows
Removes the local TinyAgents Cargo patch and advances the vendored TinyFlows commit reference.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: m3ga-mind

Poem

A rabbit hops through plans anew,
With ledgers crisp and anchors true.
Old paths fade, new pins align,
TinyFlows follows down the line.
“Hop hop!” says Bun, “the docs now rhyme!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main themes: TinyAgents v2.1 alignment and migration-plan/documentation reconciliation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4df050fe5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 22, 2026
Resolved conflicts in:
- app/src-tauri/Cargo.lock: windows-sys version bump (0.59.0 → 0.60.2)
- docs/tinycortex-memory-migration-plan.md: deletion-ledger wording
- docs/tinycortex-migration-spec.md: migration status description
- vendor/tinycortex: submodule tracking (→ 55bf066)

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/tinyagents-full-migration-plan/C4-journal-progress-parity-plan.md`:
- Around line 6-7: Align the migration plan’s deletion ownership and parity
terminology: update the S6 prerequisite statement and the S5/S6 ownership
assignments so `ProviderDelta` and `progress_tracing` have consistent deletion
ownership, then revise the §5 gate to use “journal projection parity” instead of
“V3 projection parity.”

In `@docs/tinyagents-migration-plan-2026-07-22.md`:
- Line 366: Remove the trailing space before the closing backtick in the inline
grep command under the **Exit** criterion, leaving the command content otherwise
unchanged.

In `@src/openhuman/inference/README.md`:
- Around line 16-17: Update the provider schema reference in the README text to
use the complete repository path src/openhuman/config/schema/cloud_providers.rs,
while leaving the credentials storage reference unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b12e7f13-85d9-4a5b-9a90-cc8d5cb947e1

📥 Commits

Reviewing files that changed from the base of the PR and between 49b5bb7 and b215499.

📒 Files selected for processing (14)
  • app/src-tauri/Cargo.toml
  • docs/tinyagents-drift-ledger.md
  • docs/tinyagents-full-migration-plan/99-deletion-ledger.md
  • docs/tinyagents-full-migration-plan/C4-journal-progress-parity-plan.md
  • docs/tinyagents-inference-migration-plan.md
  • docs/tinyagents-migration-plan-2026-07-22.md
  • docs/tinyagents-phase3-router-registry-design.md
  • docs/tinyagents-port-plan.md
  • src/openhuman/agent/harness/subagent_runner/mod.rs
  • src/openhuman/agent_orchestration/mod.rs
  • src/openhuman/inference/README.md
  • src/openhuman/tinyagents/subagent_graph.rs
  • src/openhuman/tools/impl/system/node_exec.rs
  • vendor/tinyflows
💤 Files with no reviewable changes (1)
  • app/src-tauri/Cargo.toml

Comment on lines +6 to +7
continuation notes, and it is the gated prerequisite for **S6 below** —
deleting the `ProviderDelta` bridge and `progress_tracing`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Align the S5/S6 deletion ownership and parity gate.

Line 6-7 says S6 deletes both ProviderDelta and progress_tracing, but Lines 173-178 assign progress_tracing to S5 and ProviderDelta to S6. Also, the updated “journal projection parity” wording at Lines 174-175 leaves the §5 gate at Lines 182-183 referring to “V3 projection parity.” Update these cross-references before this document governs deletion work.

Also applies to: 174-178

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/tinyagents-full-migration-plan/C4-journal-progress-parity-plan.md`
around lines 6 - 7, Align the migration plan’s deletion ownership and parity
terminology: update the S6 prerequisite statement and the S5/S6 ownership
assignments so `ProviderDelta` and `progress_tracing` have consistent deletion
ownership, then revise the §5 gate to use “journal projection parity” instead of
“V3 projection parity.”

`agent/harness/session/turn_tests.rs` / `subagent_runner/ops_tests.rs` to
the tinyagents path before deletion (failing-before/passing-after).

**Exit:** one turn engine; `grep -rn "OPENHUMAN_AGENT_GRAPH_" ` returns only

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Remove the space inside the code span.

The trailing space in `grep -rn "OPENHUMAN_AGENT_GRAPH_" ` violates MD038 and makes the inline command malformed.

🧰 Tools
🪛 markdownlint-cli2 (0.23.0)

[warning] 366-366: Spaces inside code span elements

(MD038, no-space-in-code)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/tinyagents-migration-plan-2026-07-22.md` at line 366, Remove the
trailing space before the closing backtick in the inline grep command under the
**Exit** criterion, leaving the command content otherwise unchanged.

Source: Linters/SAST tools

Comment on lines +16 to +17
The current matrix is `config/schema/cloud_providers.rs`; credentials are
stored under `provider:<slug>` in the auth-profile store.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Use the complete repository path for the provider schema.

The authoritative file is src/openhuman/config/schema/cloud_providers.rs; config/schema/cloud_providers.rs omits the src/openhuman/ prefix and sends readers to an invalid or ambiguous location.

Suggested correction
-  The current matrix is `config/schema/cloud_providers.rs`; credentials are
+  The current matrix is `src/openhuman/config/schema/cloud_providers.rs`; credentials are
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
The current matrix is `config/schema/cloud_providers.rs`; credentials are
stored under `provider:<slug>` in the auth-profile store.
The current matrix is `src/openhuman/config/schema/cloud_providers.rs`; credentials are
stored under `provider:<slug>` in the auth-profile store.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/openhuman/inference/README.md` around lines 16 - 17, Update the provider
schema reference in the README text to use the complete repository path
src/openhuman/config/schema/cloud_providers.rs, while leaving the credentials
storage reference unchanged.

@senamakel
senamakel merged commit 1c30d3f into tinyhumansai:main Jul 23, 2026
24 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Team Openhuman Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant