Skip to content

fix(conversations): stop the thread-goal footer text from auto-scrolling#5030

Open
jgentes wants to merge 1 commit into
tinyhumansai:mainfrom
jgentes:claude/remove-goal-scroll-animation-d2f43d
Open

fix(conversations): stop the thread-goal footer text from auto-scrolling#5030
jgentes wants to merge 1 commit into
tinyhumansai:mainfrom
jgentes:claude/remove-goal-scroll-animation-d2f43d

Conversation

@jgentes

@jgentes jgentes commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • The per-thread goal chip in the composer footer scrolls its objective text back and forth (a ping-pong marquee) whenever the text overflows. This change stops that: the label now sits still and truncates with an ellipsis.
  • Removes the now-unused goal-marquee animation + goalMarquee keyframe from the Tailwind config (grep-confirmed used nowhere else).
  • Pure presentational change — no behavior, API, or i18n changes.

Problem

When a thread goal is set, a long objective in the footer continuously animates left-and-right. It's visually distracting and pulls the eye during normal chat use, yet adds no information: the full objective is already reachable two other ways —

  • hover shows the complete text via the button's native title tooltip, and
  • click opens the goal editor, which shows the full objective in an input.

So the moving text is redundant motion with no upside, and continuous animation is an accessibility/motion concern.

Solution

  • In ThreadGoalFooterTrigger, replace the animated <MarqueeText> with a plain truncating <span> (truncate, same max-w-[18rem]), and delete the now-unused MarqueeText component.
  • Delete the goal-marquee animation entry and the goalMarquee keyframe from app/tailwind.config.js.
  • The tooltip (title) and click-to-open editor were already present and are unchanged, so no discoverability is lost.

Submission Checklist

  • Tests added or updated — N/A: no new behavior. Existing ThreadGoalChip.test.tsx (5 tests) asserts the objective renders and remains reachable via title/click, and continues to pass. A marquee-vs-truncate distinction is a visual/animation detail not meaningfully unit-testable in jsdom.
  • Diff coverage ≥ 80% — changed lines are a JSX element swap + deletions; the rendered objective span is exercised by the existing footer-trigger tests. No Rust touched.
  • Coverage matrix updated — N/A: behaviour-only (visual) change, no feature rows added/removed/renamed.
  • All affected feature IDs listed under ## RelatedN/A: no matrix feature affected.
  • No new external network dependencies introduced.
  • Manual smoke checklist updated if this touches release-cut surfaces — N/A: cosmetic tweak to an existing control.
  • Linked issue closed via Closes #NNNN/A: no tracking issue.

Impact

  • Platforms: desktop UI only (React). No CLI/core/mobile impact.
  • Performance: slightly less — one fewer running CSS animation in the footer.
  • Security/migration/compat: none.

Related

  • Closes: N/A
  • Follow-up PR(s)/TODOs: none

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: claude/remove-goal-scroll-animation-d2f43d
  • Commit SHA: 0d47263

Validation Run

  • pnpm --filter openhuman-app format:check — prettier clean on changed files
  • pnpm typecheck — passes
  • Focused tests: vitest run ThreadGoalChip.test.tsx — 5/5 pass
  • Rust fmt/check (if changed): N/A — no Rust changed
  • Tauri fmt/check (if changed): N/A — no Rust changed

Validation Blocked

  • command: git push (pre-push hook)
  • error: pre-push hook reported lint:commands-tokens (ripgrep) and a Rust check failing with "No such file or directory"
  • impact: Environment/hook-PATH artifacts only — rg and cargo are installed but not on the hook subshell PATH; neither check covers this TypeScript + Tailwind diff (no src/components/commands/ tokens, no Rust). Pushed with --no-verify per AGENTS.md guidance for unrelated pre-existing breakage. TS/lint/test/format were all run manually and pass.

Behavior Changes

  • Intended behavior change: footer goal objective no longer auto-scrolls; it truncates instead.
  • User-visible effect: the goal text in the composer footer is static; full text still available on hover (tooltip) and on click (editor).

Parity Contract

  • Legacy behavior preserved: tooltip + click-to-open editor unchanged; truncation replaces marquee only when text overflows.
  • Guard/fallback/dispatch parity checks: N/A.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): none
  • Canonical PR: this
  • Resolution: N/A

Summary by CodeRabbit

  • UI Improvements
    • Goal objectives now remain on a single line without animated scrolling.
    • Long objective text is truncated for a cleaner footer layout.
    • Hovering over truncated objectives displays the full text in a tooltip.

The composer-footer goal label used a ping-pong marquee animation whenever
the objective overflowed its max width. It scrolls continuously, which is
distracting and adds no value: the full objective is already reachable via
the button's native title tooltip (hover) and by clicking to open the editor.

Replace the animated MarqueeText with a plain truncated label, and drop the
now-unused goal-marquee animation + goalMarquee keyframe from the Tailwind
config (grep-confirmed unused elsewhere).
@jgentes
jgentes requested a review from a team July 17, 2026 22:35
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 51953899-9130-4fbb-b6cc-1ae6e877f3ce

📥 Commits

Reviewing files that changed from the base of the PR and between fb61376 and 0d47263.

📒 Files selected for processing (2)
  • app/src/features/conversations/components/ThreadGoalChip.tsx
  • app/tailwind.config.js
💤 Files with no reviewable changes (1)
  • app/tailwind.config.js

📝 Walkthrough

Walkthrough

The thread goal footer now displays long objectives as static truncated text with the existing tooltip, and removes the marquee helper, animation mapping, and keyframes.

Changes

Thread goal display

Layer / File(s) Summary
Static goal label and animation removal
app/src/features/conversations/components/ThreadGoalChip.tsx, app/tailwind.config.js
The footer uses a truncated static objective label, removes the MarqueeText helper, and deletes the associated Tailwind animation and keyframes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: senamakel

Poem

A bunny hops past scrolling words,
Now goals sit still like quiet birds.
One neat line, a tooltip near,
No dancing text to chase the ear.
Thump, thump—clean and clear!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: stopping the thread-goal footer text from auto-scrolling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant