fix(conversations): stop the thread-goal footer text from auto-scrolling#5030
fix(conversations): stop the thread-goal footer text from auto-scrolling#5030jgentes wants to merge 1 commit into
Conversation
The composer-footer goal label used a ping-pong marquee animation whenever the objective overflowed its max width. It scrolls continuously, which is distracting and adds no value: the full objective is already reachable via the button's native title tooltip (hover) and by clicking to open the editor. Replace the animated MarqueeText with a plain truncated label, and drop the now-unused goal-marquee animation + goalMarquee keyframe from the Tailwind config (grep-confirmed unused elsewhere).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe thread goal footer now displays long objectives as static truncated text with the existing tooltip, and removes the marquee helper, animation mapping, and keyframes. ChangesThread goal display
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
goal-marqueeanimation +goalMarqueekeyframe from the Tailwind config (grep-confirmed used nowhere else).Problem
When a thread goal is set, a long objective in the footer continuously animates left-and-right. It's visually distracting and pulls the eye during normal chat use, yet adds no information: the full objective is already reachable two other ways —
titletooltip, andSo the moving text is redundant motion with no upside, and continuous animation is an accessibility/motion concern.
Solution
ThreadGoalFooterTrigger, replace the animated<MarqueeText>with a plain truncating<span>(truncate, samemax-w-[18rem]), and delete the now-unusedMarqueeTextcomponent.goal-marqueeanimation entry and thegoalMarqueekeyframe fromapp/tailwind.config.js.title) and click-to-open editor were already present and are unchanged, so no discoverability is lost.Submission Checklist
N/A: no new behavior. ExistingThreadGoalChip.test.tsx(5 tests) asserts the objective renders and remains reachable via title/click, and continues to pass. A marquee-vs-truncate distinction is a visual/animation detail not meaningfully unit-testable in jsdom.N/A: behaviour-only (visual) change, no feature rows added/removed/renamed.## Related—N/A: no matrix feature affected.N/A: cosmetic tweak to an existing control.Closes #NNN—N/A: no tracking issue.Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
claude/remove-goal-scroll-animation-d2f43dValidation Run
pnpm --filter openhuman-app format:check— prettier clean on changed filespnpm typecheck— passesvitest run ThreadGoalChip.test.tsx— 5/5 passN/A— no Rust changedN/A— no Rust changedValidation Blocked
command:git push(pre-push hook)error:pre-push hook reportedlint:commands-tokens(ripgrep) and a Rust check failing with "No such file or directory"impact:Environment/hook-PATH artifacts only —rgandcargoare installed but not on the hook subshell PATH; neither check covers this TypeScript + Tailwind diff (nosrc/components/commands/tokens, no Rust). Pushed with--no-verifyper AGENTS.md guidance for unrelated pre-existing breakage. TS/lint/test/format were all run manually and pass.Behavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit