Conversation
…ut, log cap pins (#4877)
…are sandbox, unified draft handles, reference gates (#4881)
…silent trail-off) (#4887)
… runs, close resume_flow_run HITL bypass (#4889)
…gle, delete in overflow) (#4890)
… (canvas renders ≥4-node graphs) (#4888)
…-node reachability (#4891)
…isarm/create accuracy) (#4904)
…s halted at an approval gate (#4932)
… AA (#4897) Co-authored-by: Steven Enamakel <enamakel@tinyhumans.ai>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be17632f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| setDraftGraph(proposedGraph); | ||
| setPreview(null); |
There was a problem hiding this comment.
Preserve the preview until Accept actually saves
If handleSave fails here (core/network error or validation race), the copilot panel intentionally keeps the proposal card visible for retry, but these lines have already overwritten draftGraph and cleared the preview base. In that failure state, clicking Reject only calls setPreview(null) and no longer restores the pre-proposal graph/title, so the user can reject the still-visible proposal while the canvas remains changed and later save changes they thought they discarded.
Useful? React with 👍 / 👎.
| // `canvasVersion` bump above) so the ref's imperative handle is stale; | ||
| // call `handleSave` directly with the known-good proposed graph. | ||
| try { | ||
| await handleSave(proposedGraph, overrideName, proposal.requireApproval); |
There was a problem hiding this comment.
Keep outbound approval forced on accepted updates
When accepting a proposal onto an existing flow, this forwards proposal.requireApproval directly to flows_update; if the proposal JSON explicitly has require_approval: false and the graph contains outbound tool_call/http_request/code nodes, the update path honors that flag instead of applying the create-time side-effect floor, so Accept can silently turn off the human approval gate for a live workflow. This is limited to existing-flow Accepts because new draft creation goes through flows_create, which forces approval for outbound graphs.
Useful? React with 👍 / 👎.
Promote the current
mainintorelease— 22 commits ahead, no divergence (clean fast-forwardable merge, release carries nothing not already in main).Cutting staging/prod builds from
releaseafter this picks up the accumulated fixes/features below.Notable changes since the last release cut
Notes
release.releaseis strictly behindmain).promote-main-to-release.ymlworkflow dispatch; opening this as a PR for review visibility per request.