-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix(flows): builder turn-budget wiring + prompt guidance + capped UX (B31-B34) #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graycyrus
merged 7 commits into
tinyhumansai:main
from
graycyrus:fix/flows-builder-turn-budget
Jul 14, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2fb0c8a
fix(flows): builder prompt — authoritative sandbox table + minimal-gr…
graycyrus 8e5be72
fix(flows): builder session path now applies the definition's iterati…
graycyrus 1d0b8a1
feat(flows): surface a "capped" signal + Continue building UX on cap-…
graycyrus a0cd20e
Merge branch 'main' into pr/4865
M3gA-Mind 22a92fd
i18n(flows): reword capped-notice to avoid 'steps' collision (de/es/i…
M3gA-Mind 216e98b
fix(flows): accurate capped-turn copy + verify Continue resumes on-dr…
graycyrus dd15e78
test(flows): update buildWorkflow timeout assertions to 610s (B31)
graycyrus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a builder turn hits the cap before producing a proposal, the canvas graph is still the old draft and
flows_buildcreates a freshworkflow_builderagent for each RPC, so the prior tool history/checkpoint text is not included in the nextBuilderTurnRequest. In that case this button sends only the generic continue text throughsubmit()(plus the original ask viapendingAskRef), which restarts from the stale graph rather than picking up from the capped turn and can repeatedly hit the same cap. Include the checkpoint/prior transcript or a partial graph in the follow-up before advertising this as a resume action.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 216e98b. Verified:
WorkflowCopilotPanel'ssubmitalready sends the Continue turn asmode: 'revise'over the CURRENTgraphprop and the existingflowId(never a blankcreate) — so it does resume ON the built-so-far draft, not from scratch. That said,flows_build(ops.rs) spins up a freshworkflow_builderagent per RPC with no server-side tool-history/checkpoint to reattach to, so this was never a literal seamless mid-thought resume — the copy overpromised that. Rewordedflows.copilot.cappedNotice(all 14 locales) and the surrounding code comments inWorkflowCopilotPanel.tsxto accurately say Continue builds forward from the current draft (graph + accumulated instruction viapendingAskRef), not that it resumes the exact in-flight reasoning. Added a regression test asserting the Continue turn carriesflowId.