Skip to content

ci(coverage): raise RUST_MIN_STACK so llvm-cov coverage runs don't stack-overflow #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M3gA-Mind merged 2 commits into from
Jun 30, 2026
Merged

ci(coverage): raise RUST_MIN_STACK so llvm-cov coverage runs don't stack-overflow #4346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd7f2af
ci(coverage): raise RUST_MIN_STACK so llvm-cov runs don't stack-overflow
graycyrus Jun 30, 2026
253ff50
ci(coverage): bump Rust Core Coverage timeout to 50m for the full run
graycyrus Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/pr-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,11 @@ jobs:
needs: [changes, rust-quality]
if: always() && needs.changes.outputs['rust-core'] == 'true' && needs['rust-quality'].result == 'success'
runs-on: ubuntu-22.04
timeout-minutes: 30
# 30 min was only ever enough because a stack overflow aborted the run early
# (see RUST_MIN_STACK below). With the overflow fixed the job runs the full
# instrumented suite (~13.6k tests, single-threaded build) end-to-end, which
# needs more wall-time.
timeout-minutes: 50
container:
image: ghcr.io/tinyhumansai/openhuman_ci:rust-1.93.0
env:
Expand All @@ -349,6 +353,13 @@ jobs:
# the maximum-shrink setting; line-tables-only was still too large for the
# instrumented build.
CARGO_PROFILE_DEV_DEBUG: "0"
# cargo-llvm-cov instrumentation inflates per-frame stack usage, so deep
# async tests (e.g. cron::scheduler agent-job tests that drive the full
# harness) overflow the default ~2 MB test-thread stack and SIGABRT the
# whole run with "stack overflow". Give libtest's per-test threads a large
# stack so coverage runs don't abort. (Virtual reservation only — no real
# memory cost.)
RUST_MIN_STACK: "67108864"
steps:
- name: Free disk space
run: |
Expand Down Expand Up @@ -425,6 +436,9 @@ jobs:
# __llvm_covmap/__llvm_covfun sections, NOT from DWARF, so coverage
# numbers are unaffected. Mirrors rust-core-coverage.
CARGO_PROFILE_DEV_DEBUG: "0"
# Large test-thread stack so coverage instrumentation's inflated frames
# don't overflow deep async tests. Mirrors rust-core-coverage.
RUST_MIN_STACK: "67108864"
steps:
- name: Free disk space
run: |
Expand Down
Loading