feat(meet): auto-fill meeting display name from connected account#4297
Conversation
Prefill 'Your name in this meeting' from the Composio account that best matches the meeting platform (own account -> mailbox -> blank). Composio exposes only an account email, so derive a 'First Last' display name from the local part. Only prefills while the field is untouched, so it never clobbers manual input.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
MeetingBotsInline Composio prefill
🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96ce16854c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // mailbox, then blank. Slugs are canonical Composio slugs (see | ||
| // `canonicalizeComposioToolkitSlug`). | ||
| const NAME_SOURCE_TOOLKITS: Record<MeetingPlatform, string[]> = { | ||
| gmeet: ['googlemeet', 'gmail'], |
There was a problem hiding this comment.
Include Google Calendar in Meet name sources
For the Google Meet form, the common connected account is often googlecalendar (the calendar meeting flow is backed by Google Calendar, and the core's ComposioConnection.accountEmail enrichment explicitly covers Google Calendar), not googlemeet or gmail. With only a Google Calendar connection present, this priority list returns blank, so the required “Your name in this meeting” field does not auto-fill even though the matching connected account is available. Add the canonical googlecalendar slug to the gmeet sources before falling back to Gmail.
Useful? React with 👍 / 👎.
Summary
resolveMeetingDisplayName(platform, connectionByToolkit)that walks a per-platform toolkit priority — own account → mailbox → blank (e.g. Google Meet:googlemeet→gmail). Composio exposes only an account email, so the name is derived from the email local part (first.last@…→First Last).respondToTouchedRef), so a late-arriving Composio poll never clobbers manual input. The form's hardcoded'gmeet'literal is now a typedplatformconst driving both the resolver and the join payload.Notes
ComposioConnection(onlyaccountEmail), hence the derive-from-email approach.zoom/microsoft_teams/outlook/webex) are best-effort; onlygmeetis selectable in this form today, so a wrong slug just falls through to the next entry.Test plan
pnpm typecheck)Summary by CodeRabbit
New Features
Bug Fixes