fix(meet): forward wake phrase for active meeting bots#4231
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThe meeting bot submit flow now derives a wake phrase when not in listen-only mode, logs join parameters, and forwards the wake phrase in the backend join request. The localized README files update social links, native voice links, and star-history targets. ChangesMeeting bot wake phrase join flow
Localized README updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
the
agent
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/README.de.md`:
- Around line 63-69: The German README still contains an explicit TODO wrapper
around untranslated install caveats, which should not remain in the merged docs.
Update the markdown in README.de by either fully translating the mirrored
Linux/AppImage/Arch guidance or removing the TODO start/end markers if the
English text is intentionally kept; use the surrounding README.de section and
the TODO comment as the location cues.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5e35dab0-aa1b-4efe-a0f9-e4c7e9e7529f
📒 Files selected for processing (5)
docs/README.de.mddocs/README.ja-JP.mddocs/README.ko.mddocs/README.ur-pk.mddocs/README.zh-CN.md
✅ Files skipped from review due to trivial changes (2)
- docs/README.ja-JP.md
- docs/README.ko.md
|
CodeRabbit linked-issue note: the repo-side in-call response path is already present. The docstring coverage warning is not applicable to this diff: no Rust/API functions were added; the changes are frontend payload wiring, tests, and link-check-only docs maintenance. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/README.de.md`:
- Around line 65-69: The German README still contains an unresolved TODO wrapper
around the Linux/AppImage/Arch install notes. Update the docs/README.de.md
content by either translating the existing caveats into German or removing the
TODO markers if the English wording is intentionally kept, and make sure the
affected README section no longer contains the placeholder comment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1a2e9a72-8a32-473e-b247-ea88f6fa0ce0
📒 Files selected for processing (5)
docs/README.de.mddocs/README.ja-JP.mddocs/README.ko.mddocs/README.ur-pk.mddocs/README.zh-CN.md
✅ Files skipped from review due to trivial changes (2)
- docs/README.zh-CN.md
- docs/README.ko.md
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/README.de.md`:
- Around line 65-69: The German README still contains an unresolved TODO wrapper
around the Linux/AppImage/Arch install notes. Update the docs/README.de.md
content by either translating the existing caveats into German or removing the
TODO markers if the English wording is intentionally kept, and make sure the
affected README section no longer contains the placeholder comment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1a2e9a72-8a32-473e-b247-ea88f6fa0ce0
📒 Files selected for processing (5)
docs/README.de.mddocs/README.ja-JP.mddocs/README.ko.mddocs/README.ur-pk.mddocs/README.zh-CN.md
✅ Files skipped from review due to trivial changes (2)
- docs/README.zh-CN.md
- docs/README.ko.md
🛑 Comments failed to post (1)
docs/README.de.md (1)
65-69: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Unresolved TODO block from previous review.
The TODO wrapper with untranslated English install caveats remains in the German README. Either translate the Linux/AppImage/Arch guidance or remove the TODO markers if keeping the English text is intentional.
🧰 Tools
🪛 LanguageTool
[style] ~66-~66: Bei bestimmten Textarten und Formulierungen bietet es sich an, eine deutschsprachige Alternative zu benutzen.
Context: .../issues/2463) for the cause and env-var workarounds. Arch Linux package maintainers can use...(ALTERNATIVEN_FUER_ANGLIZISMEN)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/README.de.md` around lines 65 - 69, The German README still contains an unresolved TODO wrapper around the Linux/AppImage/Arch install notes. Update the docs/README.de.md content by either translating the existing caveats into German or removing the TODO markers if the English wording is intentionally kept, and make sure the affected README section no longer contains the placeholder comment.
1 participant
Summary
Hey TinyorHey Nova.wakePhrasewhen active participation is disabled.Problem
Solution
wakePhraseonly for active bots from the current persona name.wakePhrasethroughjoinMeetViaBackendBotwith the existing join options.Submission Checklist
diff-cover) meet the gate enforced by.github/workflows/pr-ci.yml. Targeted Vitest assertions cover the changed frontend payload lines; CI remains the source of truth for merged diff coverage.## Related— N/A: no matching matrix feature ID for this wake phrase payload fix.docs/RELEASE-MANUAL-SMOKE.md) — N/A: no release manual smoke surface changed.Closes #NNNin the## RelatedsectionImpact
wakePhraseoption.Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
codex/GH-4172-meet-wake-phraseb379646511faf9db549ee355ed6812047b1ab7caValidation Run
pnpm --filter openhuman-app format:checkpnpm typecheckpnpm debug unit src/components/skills/__tests__/MeetingBotsCard.test.tsx;pnpm debug unit src/services/backendMeetService.test.ts src/services/__tests__/meetCallService.test.ts; targeted ESLint forMeetingBotsCard.tsxand its test; scoped docs link grep/curl checksGGML_NATIVE=OFF pnpm rust:checkValidation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Hey <agent>address phrase when the backend emits the matching in-call request.Parity Contract
wakePhraseand do not activate the bot persona.Duplicate / Superseded PR Handling
Summary by CodeRabbit