-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(agent_meetings): wire mascotId through full stack + fix tests #3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
senamakel
merged 27 commits into
tinyhumansai:main
from
YellowSnnowmann:feat/recall-agent-customization-sync
Jun 5, 2026
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e4bd2ac
fix(onboarding,billing): surface completeAndExit errors and suppress …
YellowSnnowmann 09d7be9
test(onboarding): add RuntimeChoicePage unit tests for coverage gate
YellowSnnowmann 5417bee
style: apply prettier formatting to RuntimeChoicePage.test.tsx
YellowSnnowmann 6130121
feat(agent_meetings): forward agentName, systemPrompt, riveColors thr…
YellowSnnowmann 4927953
feat(agent_meetings): forward agentName, systemPrompt, riveColors to …
YellowSnnowmann b9b636f
fix(auth): add ngrok-skip-browser-warning header to health check and …
YellowSnnowmann daecb47
feat(agent_meetings): add mascotId wiring, fix tests, revert red back…
YellowSnnowmann cd0de16
fix(agent_meetings): address CodeRabbit review comments
YellowSnnowmann 3b8ab46
fix(tests): register backendMeet reducer in test store; add matchMedi…
YellowSnnowmann 5c4a742
test(coverage): add ActiveMeetingView + MascotFrameProducer tests to …
YellowSnnowmann 7481bf2
test(coverage): export sampleCanvasPixels and add unit tests
YellowSnnowmann ce820bd
style: run prettier on MascotFrameProducer files
YellowSnnowmann 0378992
fix(test): remove invalid eslint-disable for renamed rule
YellowSnnowmann 6265165
fix(review): address CodeRabbit and reviewer feedback
YellowSnnowmann ddd64fc
merge: upstream/main into feat/recall-agent-customization-sync
YellowSnnowmann 348ab4d
fix: address review comments — PII, RTC guard, duration cap, transcri…
YellowSnnowmann 38d6fea
merge: resolve conflict with upstream/main
YellowSnnowmann e94fc3b
fix(skills): remove unused imports and addToast prop after upstream m…
YellowSnnowmann e7eb0a6
feat(meeting-bots): add Respond To Participant and Wake Phrase fields
YellowSnnowmann 3b46b21
chore: apply pre-push auto-fixes
YellowSnnowmann 0946cc7
feat(agent_meetings): forward respondToParticipant and wakePhrase to …
YellowSnnowmann 2e4168c
i18n: rename respondToParticipant field to 'Your Name in This Meeting'
YellowSnnowmann 290351f
chore: apply pre-push auto-fixes
YellowSnnowmann 277ab8a
test(agent_meetings): add unit tests for build_join_payload and new f…
YellowSnnowmann ba36454
chore: apply pre-push auto-fixes
YellowSnnowmann fbabbe2
fix(skills): restore MeetingBotsCard toasts + guard ngrok header to d…
YellowSnnowmann 87534c9
Merge branch 'main' into feat/recall-agent-customization-sync
YellowSnnowmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts with the repo's CEF-injection rule + unrelated scope. CLAUDE.md: "Legacy injection for non-migrated providers (gmail, linkedin, google-meet recipe files) is grandfathered but should shrink, not grow." This adds a large block patching
RTCPeerConnection.prototype.{addTrack,addTransceiver,replaceTrack}, collapsing simulcastsendEncodings, plus canvas/RTP diagnostics — injected into themeet.google.comorigin, and also bumps capture 640×480→1280×720. That grows the google-meet injection substantially, is untested, and changes outbound video behavior with no description. Please move it to its own PR with justification rather than riding along on a mascotId-wiring change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
camera_bridge.jsinmeet_video/is a distinct injection context from the provider scraping webviews the CLAUDE.md rule targets. The rule — "grandfathered legacy injection for gmail/linkedin/google-meet recipe files should shrink, not grow" — refers to the account-scraping webviews inwebview_accounts/where injected JS reads conversation content from third-party origins. Themeet_video/camera_bridge.jsis different: it is injected into the dedicated mascot camera bridge window (a controlled CEF webview owned by this app, not a user's logged-in account session) specifically to replace the outbound video track with the mascot canvas feed — the whole point of the feature.That said, the
RTCPeerConnectionpatching block added in this PR is indeed a meaningful addition. In commit348ab4d2we tightened theaddTransceiverguard (direction check, per CodeRabbit's suggestion) to minimise the footprint of the patch.