Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp fix for symbolic shape view add [pr] #8337

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

chenyuxyz
Copy link
Collaborator

something is still wrong with symbolic shape shrink, but it should not recurse forever

something is still wrong with symbolic shape shrink, but it should not recurse forever
Copy link
Contributor

Changes

Name                      Lines    Diff    Tokens/Line    Diff
----------------------  -------  ------  -------------  ------
tinygrad/shape/view.py      248      +0           18.1    +0.0


total lines changes: 0

@Qazalin
Copy link
Collaborator

Qazalin commented Dec 19, 2024

ah thanks xd, I'll rebase to see the new error
is it a wrong add?

@chenyuxyz
Copy link
Collaborator Author

not sure what's considered a wrong add, but add should give either a merged view or None and never an error. feel free to add more tests and tag me if you see more

@chenyuxyz chenyuxyz merged commit 2bf47b7 into tinygrad:master Dec 19, 2024
16 checks passed
@chenyuxyz chenyuxyz deleted the view-add-loop branch December 19, 2024 21:10
@chenyuxyz
Copy link
Collaborator Author

@Qazalin you might want to check how you got this View in the first place. It broke because vm1 has contiguous=False, even though it's contiguous, and also the mask is no-op. Creating the View with View.create when possible in the tests, which would canonicalize these.

i still think it's good to not have these function fail randomly so will keep this fix and the test

@Qazalin
Copy link
Collaborator

Qazalin commented Dec 20, 2024

hmm - I'm 90% sure I just used ShapeTracker.from_shape() and __add__ of (some_st)+(some_st)
The scheduler doesn't ever construct Views manually. I'll trace back to how that View got created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants