-
-
Notifications
You must be signed in to change notification settings - Fork 260
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolves #1595 As part of our continuing effort to eliminate Ansible from our install process, this installs yq from within the bundle installer rather than during Ansible. This is a slight implementation change in that we no longer download the yq binary at install time and instead pre-download it and include it in the TinyPilot bundle. This is preferable, as it does more work in the packaging stage and less work on user devices, though it does increase the size of our bundles by a few megabytes. While we're here, we're also upgrading to the latest version of yq, so we're upgrading from `v4.30.6` to `v4.35.1`. ### Manual tests For expediency, I tested builds that combined: * #1605 * #1606 * #1608 For the manual tests, I verified: * Video works under MJPEG and H.264 * Changing video settings works In these environments: - [x] Pro Voyager build - [x] Community bundle on top of bare Raspbian system - [x] Community bundle on top of bare Raspbian system with TC358743 enabled ### Peer tests To test this bundle (which combines the stack of three PRs mentioned above), run: ```bash curl \ --silent \ --show-error \ --location \ https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \ sudo bash -s -- \ https://output.circle-artifacts.com/output/job/e70104a2-0f1f-43b7-abe9-098d6eac2799/artifacts/0/bundler/dist/tinypilot-community-20230831T0151Z-1.9.0-87+de1916a.tgz ``` <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1608"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
- Loading branch information
Showing
7 changed files
with
12 additions
and
29 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
/bundle/tinypilot | ||
/bundle/roles | ||
/bundle/*.deb | ||
/bundle/yq | ||
|
||
# Build artifacts. | ||
/dist |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters