Skip to content

Commit

Permalink
Remove legacy upgrade script (#1744)
Browse files Browse the repository at this point in the history
Related tiny-pilot/tinypilot-pro#1214

Based on our efforts to mitigate privilege escalation, the
`scripts/upgrade` script was identified as both tinypilot-writeable and
requiring root privileges. However, this script is now considered legacy
and can be removed because [it was only needed at a time when TinyPilot
could only be updated via the
terminal](https://codeapprove.com/pr/tiny-pilot/tinypilot/1743#thread-5433ea94-c337-4b07-a1cd-20651c032dd5).

<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1744"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
  • Loading branch information
jdeanwallace authored Feb 15, 2024
1 parent 5d922c4 commit 18c5bd1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ See the [CONTRIBUTING](CONTRIBUTING.md) file.
To update to the latest version of TinyPilot, run the update script:

```bash
/opt/tinypilot/scripts/upgrade && sudo reboot
sudo /opt/tinypilot-privileged/scripts/update && sudo reboot
```

## Diagnostics
Expand Down
2 changes: 1 addition & 1 deletion get-tinypilot.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ if [[ "${HAS_PRO_INSTALLED}" = 1 ]]; then
printf "Community Edition.\n\n"
printf "You probably want to update to the latest version of TinyPilot "
printf "Pro instead:\n\n"
printf " /opt/tinypilot/scripts/upgrade && sudo reboot\n"
printf " sudo /opt/tinypilot-privileged/scripts/update && sudo reboot\n"
printf "\n"
printf "If you *really* want to downgrade to TinyPilot Community Edition, "
printf "type the following:\n\n"
Expand Down
9 changes: 0 additions & 9 deletions scripts/upgrade

This file was deleted.

0 comments on commit 18c5bd1

Please sign in to comment.