Skip to content

test(machine-details): fix flaky "disarms once a save settles cleanly" (PP-78tm) #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothyfroehlich merged 2 commits into from
Sep 10, 2026
Merged

test(machine-details): fix flaky "disarms once a save settles cleanly" (PP-78tm) #2092

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aec50a
test(machine-details): fix flaky "disarms once a save settles cleanly…
claude Sep 9, 2026
76bbe44
Merge remote-tracking branch 'origin/main' into codex/PP-78tm-review
timothyfroehlich Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/app/(app)/m/[initials]/(tabs)/edit/machine-details-form.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,14 +559,20 @@ describe("MachineDetailsForm", () => {
await user.type(screen.getByLabelText(/Machine Name/), "!");
await user.click(screen.getByRole("button", { name: "Save details" }));

// The save settles the "Saved" note and tears down the beforeunload
// guard off the same isDirty flip; asserting the disarm synchronously
// right after the note settled flaked on CI (PP-78tm) — including a red
// required gate on main. Poll both together so the check waits for the
// guard to actually unsubscribe rather than sampling the settle.
// (beforeUnloadWasBlocked() dispatches a real but preventDefault-only,
// harmless beforeunload each poll.)
await waitFor(() => {
expect(screen.getByTestId("details-dirty-note")).toHaveTextContent(
"Saved"
);
expect(beforeUnloadWasBlocked()).toBe(false);
});

expect(beforeUnloadWasBlocked()).toBe(false);

await user.click(screen.getByRole("link", { name: "Settings" }));

// Queried synchronously on purpose. The armed case mounts this dialog
Expand Down
Loading