feat(pinballmap): persist checked location candidates - #2085
feat(pinballmap): persist checked location candidates#2085timothyfroehlich wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…1-checked-candidates # Conflicts: # drizzle/meta/0072_snapshot.json # drizzle/meta/_journal.json
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65b2ea5d36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62509e6faf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expectedGeneration, | ||
| snapshotJson: snapshot, |
There was a problem hiding this comment.
When an admin checks the currently tracked location and another authorized user completes an add/remove before Save, the outbound action updates snapshotJson but does not increment configurationGeneration; this candidate therefore remains valid and Save replaces the updated snapshot with the pre-mutation copy. That temporarily loses the new lineup state and can surface incorrect Missing/Lingering controls until the next sync, contrary to spec §10.9's freshly fetched snapshot requirement. Bind candidates to a state/snapshot revision changed by outbound writes and verify it transactionally at commit, or invalidate them when those writes complete. —Codex
AGENTS.md reference: AGENTS.md:L43-L46
Useful? React with 👍 / 👎.
1 participant
Summary
Test Plan
pnpm run checkpnpm run test(2,709 tests)pnpm run db:resetthrough migration 0075 and all seedspnpm run db:generatereports no schema changesEMFILEexhaustion and a stale shared GNU Parallel semaphore; exact-head CI will provide the clean-host browser resultDependencies
PR #2054 — docs(pinballmap): reconcile §10 + region alerts with Check-ID config-card design — and PR #2064 — feat(pinballmap): announce region removals (PP-o355.51.9) — are merged. This branch merged updated
mainafter PR #2064 and regenerated the candidate migration as 0075 per the Drizzle conflict protocol.Related Issues
Bead PP-o355.51.6.2.1
—Codex-PBMConfigCard