Skip to content

Adapt signature of frontend methods. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srobotta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adapt signature of frontend methods. #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions classes/frontend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ protected function get_javascript_strings(): array {
return ['label_state', 'label_question', 'ajaxerror'];
}

protected function get_javascript_init_params($course, \cm_info $cm = null,
\section_info $section = null): array {
protected function get_javascript_init_params($course, ?\cm_info $cm = null,
?\section_info $section = null): array {

// Get all quizzes for course.
$quizzes = $this->get_all_quizzes($course->id);
Expand Down Expand Up @@ -74,8 +74,8 @@ protected function get_all_quizzes(int $courseid): array {
return $this->allquizzes;
}

protected function allow_add($course, \cm_info $cm = null,
\section_info $section = null): bool {
protected function allow_add($course, ?\cm_info $cm = null,
?\section_info $section = null): bool {

// Only show this option if there are some quizzes in the course.
return !empty($this->get_all_quizzes($course->id));
Expand Down