You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
I'd rather not change dependencies compatibility on the current branch because some users are embedding the server runtime directly in their application code.
Do you really need some log4j2 specific feature or is your goal to get rid of detected CVEs ?
For now, I chose a simpler path which is replacing the log4j dependency by reload4j (which is a binary compatible, maintained fork of log4j 1.x)
Note that the client part of FFMQ is only using the commons-logging facade, which you can adapt to whatever logging backend you need by adding one more wrapper (jcl-over-slf4j)
In the future I may create a new branch to modernize a bit the code :
raise minimum JRE to 8, replace commons-logging by slf4j-api, ...
Hello, I'd rather not change dependencies compatibility on the current branch because some users are embedding the server runtime directly in their application code.
Do you really need some log4j2 specific feature or is your goal to get rid of detected CVEs ? For now, I chose a simpler path which is replacing the log4j dependency by reload4j (which is a binary compatible, maintained fork of log4j 1.x)
Actualy, I don't need, the goal was just to get rid of teh CVE
Note that the client part of FFMQ is only using the commons-logging facade, which you can adapt to whatever logging backend you need by adding one more wrapper (jcl-over-slf4j)
In the future I may create a new branch to modernize a bit the code : raise minimum JRE to 8, replace commons-logging by slf4j-api, ...
Ok, super !
Thanks for your work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR fix the CVE-2019-17571