Fix work_mem recommendation to not be too low #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the inputs, the work_mem formulas could potentially return values below 64KB, which is invalid and blocks PostgreSQL from starting. These changes ensure that work_mem is always at least 64KB. Also remove an unused regex in pkg/tstune
RobAtticus
force-pushed
the
rrk/work-mem-min
branch
from
51e8b3a to
baaec8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 90.11% 90.17% +0.06%
==========================================
Files 16 16
Lines 809 814 +5
==========================================
+ Hits 729 734 +5
Misses 68 68
Partials 12 12
Continue to review full report at Codecov.
|
atanasovskib
approved these changes
Mar 5, 2019
perrygeo
approved these changes
Mar 5, 2019
LeeHampton
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the inputs, the work_mem formulas could potentially return
values below 64KB, which is invalid and blocks PostgreSQL from
starting. These changes ensure that work_mem is always at least
64KB.
Fixes #38