Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Remove nbdev
I did a few things to get rid of nbdev so far, thought I'd already open a PR to discuss how to move forward:
1. Moved examples into simple pytest code
These are not quite idiomatic test functions right now:
I would aim to clean them up in the future. However there is value in continuing to run the exact example code in tests as nbdev used to do. This guarantees that users of the library have a smooth experience when reading and experimenting with the docs.
2. Removed nbdev specific comments and files
3. Moved the build and dependency system to
poetryuvThis is simply the tool I am most familiar with, happy to useuv
instead if we decide this is the better way to go. It is definitely more compliant with newer PEPs.4. Correctly identified 3.10 as the minimal python version
There is simply some
isinstance(Union)
code that doesn't work in python <= 3.9 it was previously labelled wrongly as compatible.5. Installed ruff for formatting and linting
I tried to also fix linting errors but there is still 70 left, I'd fix this in a separate PR.
What else is missing?
1. CI hasn't been changed at all yet
Tests are skipped right now anyways and I cannot simply run pytest due to the problems mentioned in 1.). I also haven't adapted the build action yet. I am not sure if I should do this considering the goal is to merge this with pgai (and subsequently we have to unify the build and dependency mangement there anyway).
2. Notebooks are sitll present in the nbs folder
I think there is probably some value in having example notebooks around and maybe even generate the docs from them? Happy to discuss this further, didn't put much thought into this yet.