Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove list of deprecated features. #3258

Conversation

billy-the-fish
Copy link
Contributor

Description

[Short summary of why you created this PR]

Links

Fixes #[insert issue link, if any]

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-3256-feedback-remove-the-section-on-distributed-hypertables-in-timescaledb-editions-page

…buted-hypertables-in-timescaledb-editions-page
…buted-hypertables-in-timescaledb-editions-page
<td><a href="https://docs.timescale.com/api/latest/distributed-hypertables/move_chunk_experimental/">move_chunk</a></td>
<td>❌</td>
<td>✅</td>
<td colspan="3"><strong>Distributed hypertables</strong>: This feature is deprecated in all editions.</td>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramonguiu, are you ok with me removing the list for a deprecated features?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @billy-the-fish - makes sense to me, no reason to keep those deprecated features around any more. Not sure if we should even keep this line around anymore, but your call.

If we keep the line, should we add something like the following? (non-blocking comment for your consideration)

+     <td colspan="3"><strong>Distributed hypertables</strong>: This feature is deprecated in all editions after TimescaleDB 2.13. Learn more about it [here](https://github.com/timescale/timescaledb/blob/2.14.0/docs/MultiNodeDeprecation.md).</td>

…buted-hypertables-in-timescaledb-editions-page
Signed-off-by: Iain Cox <[email protected]>
@billy-the-fish billy-the-fish merged commit f86e062 into latest Jul 4, 2024
3 checks passed
@billy-the-fish billy-the-fish deleted the 3256-feedback-remove-the-section-on-distributed-hypertables-in-timescaledb-editions-page branch July 4, 2024 08:21
billy-the-fish added a commit that referenced this pull request Aug 1, 2024
* fix: remove list of deprecated features.
billy-the-fish added a commit that referenced this pull request Aug 12, 2024
* fix: remove list of deprecated features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feedback] Remove the section on "Distributed hypertables" in TimescaleDB editions page
3 participants