Make modify volume interval configurable #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
2 times, most recently
from
936a5b7 to
7b70312
Compare
adolsalamanca
force-pushed
the
adol/bump-to-1.25
branch
from
93b5c86 to
689868c
Compare
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
from
7b70312 to
e075618
Compare
adolsalamanca
force-pushed
the
adol/bump-to-1.25
branch
from
689868c to
ec1e45a
Compare
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
2 times, most recently
from
5f6fc61 to
e2ebcb5
Compare
adolsalamanca
force-pushed
the
adol/bump-to-1.25
branch
from
ec1e45a to
a42b00e
Compare
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
from
e2ebcb5 to
3c35138
Compare
minkimipt
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
we need to build an image with this one and replace the original 1.25 image with it here https://github.com/timescale/savannah-infra/pull/2274/commits/3aba59ff5bcfb3d033cfe2636e08ac237a925efd
That's correct, CI has been tweaked for that, I've been doing some tests with a custom tag |
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
3 times, most recently
from
933d44b to
27d3eda
Compare
|
|
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
3 times, most recently
from
93f3c0f to
f8f29c8
Compare
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
3 times, most recently
from
08687a8 to
13d2a7d
Compare
We're having problems related to race conditions when several changes are applied to volumes. We don't want those changes to be applied independently, so we're extracting this param to a driverOption to make it configurable from the outside.
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
from
13d2a7d to
2a9dfde
Compare
adolsalamanca
force-pushed
the
adol/make-modify-volume-interval-configurable
branch
from
d22f129 to
36f80d8
Compare
adolsalamanca
deleted the
adol/make-modify-volume-interval-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having problems related to race conditions when several changes are applied to volumes. We don't want those changes to be applied independently, so we're extracting this param to a driverOption to make it configurable from the outside.
Issue
Addresses the need described in this issue