modernize helper and core logic, improve network handling #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor JSON fetching logic and improve error handling.
Added new configuration options for HTTP requests and improved error handling in JSON processing. Allow nested array
Refactor code for improved readability and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimizes both the front-end and node_helper.js logic
Allow nested array
Rewrote node_helper.js
Improved network handling: can now run api calls from a server instead of on client.
e.g. if server is within a local network that does local api calls.
And client is remote outside network.
Added proper timeout and redirect handling.
Tested with both local and external API endpoints — behavior should be unchanged for existing users.