Skip to content

fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnieXu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(sparking-cli): Fix spawn rspeedy ENOENT error when running npm run run:android on Windows #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66aab51
fix(sparking-cli): (Windows) Failed to load app config via ESM
JohnieXu Apr 24, 2026
fec1616
fix(sparkling-app-cli): resolve spawn rspeedy ENOENT and ESM config l…
JohnieXu Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/sparkling-app-cli/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,10 @@ function loadAppConfigViaEsm(cwd: string, configPath: string, originalError?: un
const tempDir = path.resolve(cwd, '.sparkling');
fs.mkdirSync(tempDir, { recursive: true });
const readerScript = path.join(tempDir, 'read-app-config.mjs');
const fileUrl = pathToFileURL(configPath).href;
// On Windows with Node.js v24, pathToFileURL has a bug with backslash paths
// Convert to forward slashes before passing to pathToFileURL
const normalizedPath = configPath.split(path.sep).join('/');
const fileUrl = pathToFileURL(normalizedPath).href;
const script = [
`const url = ${JSON.stringify(fileUrl)};`,
'const mod = await import(url);',
Expand All @@ -239,6 +242,7 @@ function loadAppConfigViaEsm(cwd: string, configPath: string, originalError?: un
cwd,
stdio: ['ignore', 'pipe', 'pipe'],
env: process.env,
shell: process.platform === 'win32' ? true : false,
});

if (res.status !== 0) {
Expand Down
2 changes: 1 addition & 1 deletion packages/sparkling-app-cli/src/utils/exec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export async function runCommand(
cwd: options.cwd,
env: { ...process.env, ...options.env },
stdio: 'inherit',
shell: false,
shell: process.platform === 'win32' ? true : false,
});

await new Promise<void>((resolve, reject) => {
Expand Down