Fixed data reader creation return value handling #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kordets
force-pushed
the
fix-uxrce-reader-creation
branch
2 times, most recently
from
954cef0 to
43d48b3
Compare
kordets
force-pushed
the
fix-uxrce-reader-creation
branch
from
43d48b3 to
13bbcbf
Compare
jlaitine
requested changes
Jan 17, 2025
| @@ -157,7 +157,7 @@ bool RcvTopicsPubs::init(uxrSession *session, uxrStreamId reliable_out_stream_id | |||
| @[ for idx, sub in enumerate(subscriptions)]@ | |||
| { | |||
| uint16_t queue_depth = uORB::DefaultQueueSize<@(sub['simple_base_type'])_s>::value * 2; // use a bit larger queue size than internal | |||
| ret = create_data_reader(session, reliable_out_stream_id, best_effort_in_stream_id, participant_id, @(idx), client_namespace, "@(sub['topic_name'])", "@(sub['dds_type'])", queue_depth); | |||
| ret = ret & create_data_reader(session, reliable_out_stream_id, best_effort_in_stream_id, participant_id, @(idx), client_namespace, "@(sub['topic_name'])", "@(sub['dds_type'])", queue_depth); | |||
There was a problem hiding this comment.
BItwise and is not nice for this (consider e.g. 1 & 2). Or, first iteration returning 1 and second 0...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ammendment to previous fix where previously it was only handling the case in reader creation where only the last topic would define the return value for the reader creation.