Repository navigation
Merge upstream 07092026 - #5
Conversation
…ubev2v#8268) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=1c5b72b79aad278e212e1fb80bbafe3a69844273' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `8c0cb52` -> `2293ca7` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ubev2v#8271) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=b93d46b4db167a7c4d0905a6affac42d42e76f92' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `2293ca7` -> `da1f774` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ubev2v#8270) Both remove_duplicate_persistent_routes scripts (standard and registry variants) filtered routes to IPv4-only, leaving stale IPv6 persistent routes untouched after migrating from an IPv6 ESXi host. Changes: - Remove the IPv4-only filter so all address families are processed - Guard route.exe fallbacks with AddressFamily==IPv4 - Extend default gateway detection to include ::/0 alongside 0.0.0.0/0 - Add IPv6 gateway configuration in Step 4 using New-NetRoute (standard variant) and New-NetRoute cmdlet (registry variant, since Tcpip registry is IPv4-only) - Widen stale-route sweep (Step 3) to cover both IPv4 and IPv6 - Fix duplicate gateway cleanup: check PersistentStore directly instead of Get-NetIPConfiguration (which reflects active routes and falsely skips the re-add) - Add IPv6 route re-add fallback using 'netsh set route' to make existing active routes persistent when New-NetRoute -PolicyStore PersistentStore is unsupported (Windows Server 2019 compat) Ref: https://redhat.atlassian.net/browse/MTV-6500 Resolves: MTV-6500 Signed-off-by: Elad Hazan <ehazan@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=0f59f9e6b95e8232b4ea954595de02b1490f6465' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/virt-v2v-rhel9-dev-preview | digest | `e9cb5c3` -> `3664326` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…8272) The Hyper-V builder's TemplateLabels() returned an empty label map, causing findTemplate() to match all KubeVirt templates and select the newest by creation time. This resulted in incorrect templates being applied (e.g. a RHEL 8 VM getting windows10-highperformance). Populate TemplateLabels() by fetching the VM's GuestOS from inventory and mapping it to the corresponding KubeVirt template OS identifier (e.g. "rhel8.1", "win2k19") via a new mapHypervGuestOS() function. Ref: https://redhat.atlassian.net/browse/MTV-6508 Resolves: MTV-6508 Signed-off-by: Elad Hazan <ehazan@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=c5fe79a4be62b68ef5dc5bf76e7ed14d19fe10a7' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `84cf438` -> `e240bfc` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8277) Image created from 'https://github.com/kubev2v/forklift?rev=c5fe79a4be62b68ef5dc5bf76e7ed14d19fe10a7' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `ce762b7` -> `56902c7` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ubev2v#8278) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=950189702b42dbe17df5ac6d2398ee81193eb385' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `da1f774` -> `f264f3a` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: Kyl-Bempah <24903083+Kyl-Bempah@users.noreply.github.com>
…ev2v#8288) Image created from 'https://github.com/kubev2v/forklift?rev=c166258990064ead26b150e161fdbc52e7b21ef9' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/deep-inspection-rhel9-dev-preview | digest | `6efbead` -> `a5bb497` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8289) This PR updates the SHA references in Containerfile-downstream files based on the latest snapshot for version dev-preview. ## Changes - Updated SHA references in all Containerfile-downstream files - Generated from latest snapshot: forklift-operator-dev-preview-20260825-051317-000 ## Automated Update This PR was created automatically by the mtv-releng update script. Signed-off-by: solenoci <solenoci@redhat.com>
…to dedicated table (kubev2v#8250) An issue was found in using forklift to move VMs from vSphere where there was a large amount of custom value definitions. It resulted in a very large inventory database as well as very high memory consumption of the inventory container when the plans were reconciling. This was due to the entire custom value definition being added to each VM in the VM table. In the test case there were over 1200 custom value definitions where all were used, but most VMs only used a few each. In that case about 95% of the entire inventory DB was the custom value definitions. Originally, I thought to make the changes entirely within the inventory so the consumer did not need to be changed where at the time of the data being committed to the database, the custom value definitions were for each VM would be pruned to only the values that VM had defined. But when an incremental change is made where a value is added to a VM, the definitions are not resent and it would have resulted in annotations being excluded until the next time the pod was restarted. Instead, I opted to move the custom value definitions into a separate database table and endpoint and have the consumer merge the data together. This allows for the data in the DB to be reduced from n (VMs) to 1 as well as the amount of data passed by each of the calls to the inventory will be reduced by the size of the custom value definition at the expense of 1 additional call per VM to collect the custom value definitions. Ref: https://redhat.atlassian.net/browse/MTV-6511 Signed-off-by: Tyler Muir <tylergmuir@gmail.com>
…2v#8291) Image created from 'https://github.com/kubev2v/forklift?rev=87de40160dfbbf47c5d1680b85c2abcbc20fd634' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `56902c7` -> `e8b8ebe` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=87de40160dfbbf47c5d1680b85c2abcbc20fd634' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `e240bfc` -> `64ca83f` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
… CR pods (kubev2v#7943) The extra-v2v-conf and vddk-conf ConfigMap volumes were added to volumes/mounts but not to extraVolumes/extraMounts in podVolumeMounts. When UseConversionCR is enabled (default), EnsureConversion filters non-PVC volumes while populating the the Conversion CR. Since these ConfigMap volumes were missing from extraVolumes, they were silently dropped from the final pod spec, causing: - extra-v2v-conf: "No such file or directory" when referenced via VIRT_V2V_EXTRA_ARGS (-io vddk-config=/mnt/extra-v2v-conf/...) - vddk-conf: VDDK AIO optimization silently not applied even when useVddkAioOptimization is enabled on the provider Resolves: https://redhat.atlassian.net/browse/MTV-6335 Signed-off-by: Nijin Ashok <nashok@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=beee8ba905e6cd32c974255e3f961f80b20bf062' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `64ca83f` -> `80281d8` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8296) Image created from 'https://github.com/kubev2v/forklift?rev=beee8ba905e6cd32c974255e3f961f80b20bf062' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `e8b8ebe` -> `1c3ac2e` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
OCP no longer validates source MACs against destination VMs. The source VM is already off, or will be shut down after migration, so the MAC is not used on both sides. Test and test run logs in the ticket. Ref: https://redhat.atlassian.net/browse/MTV-6524 Resolves: MTV-6524 Signed-off-by: yaacov <yzamir@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=8b6a6eda217d8a028e3294bd6e18f22a9fe4675d' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `80281d8` -> `abf7ff6` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8299) Image created from 'https://github.com/kubev2v/forklift?rev=8b6a6eda217d8a028e3294bd6e18f22a9fe4675d' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `1c3ac2e` -> `95de426` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Introduce a guestIPConfig field (preserve/dhcp/none) on NetworkPair entries in the NetworkMap CRD, allowing per-NIC control over whether static IPs are preserved during migration. This overrides the plan-level preserveStaticIPs flag on a per-network basis. Changes: - Add GuestIPConfig type and field to NetworkPair in mapping.go - Add validation rejecting guestIPConfig on ignored destinations - Add ResolveNICModes() and HasPreserveMode() helpers in base package - Modify vSphere and HyperV builders to filter mapMacStaticIps by mode Ref: https://redhat.atlassian.net/browse/MTV-5674 Resolves: MTV-5674 Signed-off-by: Elad Hazan <ehazan@redhat.com>
…ubev2v#8301) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=c25c41c851a9f394a2bd3dce723e3af5d82aefbf' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `f264f3a` -> `ebfbb18` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…#8302) Image created from 'https://github.com/kubev2v/forklift?rev=133eb141508a452184eed5a3402e196c73b8347e' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-operator-dev-preview | digest | `e219502` -> `c7c4c37` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8303) Image created from 'https://github.com/kubev2v/forklift?rev=133eb141508a452184eed5a3402e196c73b8347e' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `95de426` -> `a182e9b` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=133eb141508a452184eed5a3402e196c73b8347e' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `abf7ff6` -> `cb80e8f` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…6339 (kubev2v#8305) Image created from 'https://github.com/kubev2v/forklift?rev=133eb141508a452184eed5a3402e196c73b8347e' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/vsphere-copy-offload-populator-dev-preview | digest | `cd04ac0` -> `04a6339` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ubev2v#8306) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=5e3e82d1e9c4b26863a4397f1b58229b06a892a6' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `ebfbb18` -> `10dbf27` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Following on from kubev2v#7657, create an actual workflow that gets a VM migrated from Nutanix. This creates a temporary Image from a VM disk on the Nutanix side, and transfers it over an HTTP DataVolume importer. This is the least fancy option in that it copies every byte from the source whether or not it was actually used, but it should work whether the provider is Prism Central or Prism Element. Does not run a conversion yet as existing VirtIO drivers seem to work, this will be revisited in a future pull request. Reference: [MTV-6234](https://redhat.atlassian.net/browse/MTV-6234) Resolves: MTV-6234 [MTV-6234]: https://redhat.atlassian.net/browse/MTV-6234?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Signed-off-by: Matthew Arnold <marnold@redhat.com> Signed-off-by: mrnold-agent <279805359+mrnold-agent@users.noreply.github.com> Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com> Co-authored-by: mrnold-agent <279805359+mrnold-agent@users.noreply.github.com> Co-authored-by: Jonathon Jongsma <jjongsma@redhat.com>
…2v#8309) Image created from 'https://github.com/kubev2v/forklift?rev=192883389528839d7a422f2ade929c37d29b53b9' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `a182e9b` -> `a5b1487` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=192883389528839d7a422f2ade929c37d29b53b9' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `cb80e8f` -> `3f04346` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=434cb2a4423849d071270a0eaeae48631dbf67c9' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/virt-v2v-rhel9-dev-preview | digest | `c25e749` -> `69b6b91` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8424) This PR updates the SHA references in Containerfile-downstream files based on the latest snapshot for version dev-preview. ## Changes - Updated SHA references in all Containerfile-downstream files - Generated from latest snapshot: forklift-operator-dev-preview-20260903-222025-000 ## Automated Update This PR was created automatically by the mtv-releng update script. Signed-off-by: solenoci <solenoci@redhat.com> Co-authored-by: solenoci <solenoci@redhat.com>
…ubev2v#8417) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=1e903eb42ec8bcd4cdc00f989dc1d22148d8fda5' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `cd20e1d` -> `fab6553` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Issue: In a clustered Hyper-V environment, PowerOff issues this chain: WinRM → entry-point host → Invoke-Command -ComputerName <owner-node> → Stop-VM -Force On large clusters the default 60s WinRM timeout can be exceeded, causing: 1. WinRM returns "context deadline exceeded" 2. PowerOff wraps it as "failed to power off the vm..." 3. PhasePowerOffSource calls step.AddError(), which is terminal: it sets vm.Error, the VM is marked PhaseCompleted + ConditionFailed, and the migration never retries. Fix: 1. Use RunOnNodeWithTimeout with a 5-minute timeout instead of RunOnNode with the default 60s timeout. 2. If Stop-VM still times out, PowerOff returns nil instead of an error. This is safe because Stop-VM -Force is accepted by VMMS before the WinRM response completes. Returning nil lets PhasePowerOffSource advance to WaitForPowerOff, which polls the actual VM power state via WinRM until the VM is truly off. Resolves: MTV-6639 Signed-off-by: Elad Hazan <ehazan@redhat.com>
Image created from 'https://github.com/kubev2v/forklift?rev=cf4caf6a3b6acf7bba87bbf9f0af1159739c7cf6' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `52b265f` -> `86ae109` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8437) Image created from 'https://github.com/kubev2v/forklift?rev=cf4caf6a3b6acf7bba87bbf9f0af1159739c7cf6' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `7ab28bd` -> `7e1b01f` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Align local lint fixes with the golangci-lint GitHub Action upgrade in kubev2v#5882 Most issues were resolved with `golangci-lint run --fix` (embedded-field selector simplifications, Ginkgo assertion style, formatting). Remaining findings were fixed manually where auto-fix did not apply. Harder to fix errors like variable renames (ST1012) are intentionally left for a follow-up. Signed-off-by: yaacov <yzamir@redhat.com>
…bev2v#8440) Image created from 'https://github.com/kubev2v/forklift?rev=aadbb7a5b26c5ef6653e0e31e45258f7680d30a2' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/hyperv-provider-server-dev-preview | digest | `c4586ca` -> `96f6ac0` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=aadbb7a5b26c5ef6653e0e31e45258f7680d30a2' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `86ae109` -> `b070990` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…95e7 (kubev2v#8442) Image created from 'https://github.com/kubev2v/forklift?rev=aadbb7a5b26c5ef6653e0e31e45258f7680d30a2' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/vsphere-copy-offload-populator-dev-preview | digest | `8453c20` -> `99795e7` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8443) Image created from 'https://github.com/kubev2v/forklift?rev=aadbb7a5b26c5ef6653e0e31e45258f7680d30a2' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `7e1b01f` -> `2267aae` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Address errcheck and low-risk staticcheck issues left after the v2.12 upgrade (kubev2v#8439). Aligns local make lint with the golangci-lint GitHub Action changes from kubev2v#5882. - Check ignored Close/Write return values (defer func pattern) - Fix ST1005 error string style and ST1019 duplicate imports - Suppress ST1012 on legacy exported error names with targeted nolint comments pending a dedicated rename follow-up Signed-off-by: yaacov <yzamir@redhat.com>
) Image created from 'https://github.com/kubev2v/forklift?rev=8f83b29772462db908e4e5fe34e173e1dafc788c' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/ovirt-populator-dev-preview | digest | `46016cc` -> `efb4498` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…bev2v#8446) Image created from 'https://github.com/kubev2v/forklift?rev=8f83b29772462db908e4e5fe34e173e1dafc788c' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/hyperv-provider-server-dev-preview | digest | `96f6ac0` -> `0d361eb` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…2v#8447) Image created from 'https://github.com/kubev2v/forklift?rev=8f83b29772462db908e4e5fe34e173e1dafc788c' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-controller-dev-preview | digest | `2267aae` -> `3f39e16` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=8f83b29772462db908e4e5fe34e173e1dafc788c' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-api-dev-preview | digest | `b070990` -> `d2fd06a` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…f4d1 (kubev2v#8449) Image created from 'https://github.com/kubev2v/forklift?rev=8f83b29772462db908e4e5fe34e173e1dafc788c' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/vsphere-copy-offload-populator-dev-preview | digest | `99795e7` -> `ed8f4d1` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Image created from 'https://github.com/kubev2v/forklift?rev=8f83b29772462db908e4e5fe34e173e1dafc788c' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/virt-v2v-rhel9-dev-preview | digest | `69b6b91` -> `435d5cd` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
On IPv6-only OCP clusters the console plugin fails with "Failed to get a valid plugin manifest" because nginx is configured with `listen 9443 ssl` which only binds to IPv4. Simply adding both IPv4 and IPv6 listen directives does not work either, as nginx refuses to start on IPv6-only clusters when it cannot bind to 0.0.0.0. Apply the same runtime detection pattern used by the OpenShift cluster-monitoring-operator (PR kubev2v#2173): inject POD_IP via the Kubernetes downward API, detect the IP family at container startup, and substitute the correct listen address into the nginx config via sed. Resolves: MTV-3116 Signed-off-by: Aviv Turgeman <aturgema@redhat.com> Made-with: Cursor
…#8451) Image created from 'https://github.com/kubev2v/forklift?rev=b6bc2f4be6db9099561b657ec6f401788435b0a7' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-operator-dev-preview | digest | `737d334` -> `1ec5f0f` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: Martin Necas <mnecas@redhat.com>
…ubev2v#8454) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=95141f657bae26b66e5ee9800c24574aa0d5dfac' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `fab6553` -> `3101427` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ubev2v#8458) Image created from 'https://github.com/kubev2v/forklift-console-plugin?rev=07e50ead6b517ec36ab5ae634c126a311a1a8ac5' This PR contains the following updates: | Package | Update | Change | |---|---|---| | quay.io/redhat-user-workloads/rh-mtv-1-tenant/forklift-operator-dev-preview/forklift-console-plugin-dev-preview | digest | `3101427` -> `2544824` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- To execute skipped test pipelines write comment `/ok-to-test` This is Konflux nudging PR, not Mintmaker. <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4yNi41LXJwbSIsInVwZGF0ZWRJblZlciI6IjQyLjI2LjUtcnBtIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJrb25mbHV4LW51ZGdlIl19--> Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com> Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
|
There was a problem hiding this comment.
🟡 Changes recommended
The PR introduces multiple compile-breaking reflect.Pointer usages (should be reflect.Ptr) and includes at least one inconsistent test update that will fail or not compile.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR merges upstream changes that expand migration/configuration capabilities (notably vSphere disk exclusion and per-network IP handling), update vendored dependencies, and refactor multiple components to newer embedded-field APIs and settings access patterns.
Changes:
- Add vSphere VM
excludeDiskssupport (API/CRDs/docs/tests) and route such plans to the CDI transfer path. - Add
networkIPModeto network map pairs plus controller-side validation for invalid destination/mode combinations. - Update vendored dependencies and multiple controllers/CLIs for upstream refactors (settings flattening, embedded field access, new provider capabilities, virt-v2v/VDDK/NFC handling, IPv6 URL handling).
File summaries
| File | Description |
|---|---|
| vendor/modules.txt | Bump vendored module version |
| vendor/github.com/kubev2v/vm-migration-detective/internal/inspection/virt_v2v_open.go | IPv6 + VDDK/NFC selection |
| vendor/github.com/kubev2v/vm-migration-detective/internal/inspection/virt_v2v_inspector.go | IPv6 + plugin selection/args |
| vendor/github.com/kubev2v/vm-migration-detective/internal/inspection/virt_inspector.go | Better ctx cancel handling |
| vendor/github.com/kubev2v/vm-migration-detective/internal/cmdbuilder/cmdbuilder.go | Return ctx.Err on cancel |
| renovate.json | Disable Renovate on EOL branches |
| pkg/virt-v2v/utils/xml-reader.go | Normalize XML unmarshal error |
| pkg/virt-v2v/utils/xml_reader_test.go | Ignore cleanup errors |
| pkg/virt-v2v/utils/filesystem_test.go | Ignore cleanup errors |
| pkg/virt-v2v/server/server_test.go | Ignore cleanup errors |
| pkg/virt-v2v/config/variables.go | Add NFC plugin config vars |
| pkg/settings/settings.go | Settings flattening (VDDK image) |
| pkg/settings/migration.go | Role/settings refactor + msgs |
| pkg/provider/testutil/fixtures.go | Plan reference struct refactor |
| pkg/provider/testutil/context.go | Plan reference struct refactor |
| pkg/provider/ec2/inventory/collector/collector_test.go | Ignore close/remove errors |
| pkg/provider/ec2/controller/validator/validator_test.go | Validator struct field refactor |
| pkg/provider/ec2/controller/validator/noop.go | Add ExcludedDisks no-op |
| pkg/provider/ec2/controller/validator/migration.go | Use r.Plan instead of Context |
| pkg/provider/ec2/controller/migrator/core.go | Use r.Plan instead of Context |
| pkg/provider/ec2/controller/ensurer/volumes.go | Use embedded client methods |
| pkg/provider/ec2/controller/builder/volumes.go | Use embedded annotations field |
| pkg/provider/ec2/controller/builder/noop.go | Add DV helper no-ops |
| pkg/lib/util/util.go | Ignore Close() error |
| pkg/lib/util/sshutils.go | Ignore Close() errors in defers |
| pkg/lib/ref/ref_test.go | Gomega matcher modernizations |
| pkg/lib/ref/predicate.go | Pointer-kind check refactor |
| pkg/lib/logging/gin_test.go | Ignore Close() errors |
| pkg/lib/itinerary/simple.go | Lint suppression + method calls |
| pkg/lib/itinerary/simple_test.go | Gomega matcher modernizations |
| pkg/lib/inventory/web/client.go | Defer-close handling + pointer kind |
| pkg/lib/inventory/model/table.go | Lint suppression + pointer kind |
| pkg/lib/inventory/model/model.go | Pointer-kind refactor |
| pkg/lib/inventory/model/inspect.go | Pointer-kind refactor + model PK |
| pkg/lib/inventory/model/field.go | Pointer-kind refactor |
| pkg/lib/hyperv/driver/driver.go | Add timeout-capable driver APIs |
| pkg/lib/filebacked/list_test.go | Gomega matcher modernizations |
| pkg/lib/filebacked/catalog.go | Pointer-kind refactor |
| pkg/lib/error/error_test.go | Test matcher refactors |
| pkg/lib/condition/condition_test.go | Gomega matcher modernizations |
| pkg/lib/cmd/inventory/main.go | Handler prepare refactor |
| pkg/lib/client/openshift/client.go | Use embedded TLS fields |
| pkg/lib/client/openshift/client_test.go | Align tests with embedded fields |
| pkg/lib/client/nutanix/api_test.go | Add Nutanix client unit tests |
| pkg/lib/aap/client.go | Ignore response body close errors |
| pkg/lib/aap/client_test.go | Switch statement simplification |
| pkg/lib-volume-populator/populator-machinery/metrics.go | String comparison cleanup |
| pkg/lib-volume-populator/populator-machinery/metrics_test.go | Ignore response body close errors |
| pkg/lib-volume-populator/populator-machinery/controller.go | String comparison cleanup + embeds |
| pkg/forklift-api/webhooks/validating-webhook/admitters/plan-admitter.go | Plan ref struct refactor |
| pkg/forklift-api/webhooks/util/util.go | Error message casing normalization |
| pkg/forklift-api/webhooks/mutating-webhook/mutators/secret-mutator.go | Ignore response body close errors |
| pkg/controller/validation/policy/client.go | Settings/client method refactor |
| pkg/controller/provider/web/vsphere/workload.go | Fix ID usage + flatten With() calls |
| pkg/controller/provider/web/vsphere/vm.go | Add excluded disk filtering |
| pkg/controller/provider/web/vsphere/vddk.go | Handler prepare refactor + defers |
| pkg/controller/provider/web/vsphere/doc.go | Register CustomFieldDef handler |
| pkg/controller/provider/web/vsphere/customfielddef_test.go | Add CustomFieldDef handler tests |
| pkg/controller/provider/web/vsphere/client.go | Add resolver path for CustomFieldDef |
| pkg/controller/provider/web/ovirt/workload.go | Fix ID usage |
| pkg/controller/provider/web/openstack/workload.go | Flatten With() calls |
| pkg/controller/provider/web/openstack/image.go | Flatten embedded fields usage |
| pkg/controller/provider/web/ocp/namespace.go | Use embedded UID field |
| pkg/controller/provider/web/ocp/base.go | Use embedded client methods |
| pkg/controller/provider/web/hyperv/types.go | Resolver UID refactor |
| pkg/controller/provider/web/base/client.go | Pointer-kind refactor + path calls |
| pkg/controller/provider/web/base/client_test.go | Settings flattening test updates |
| pkg/controller/provider/web/base/auth.go | Use embedded UID field |
| pkg/controller/provider/validation/doc.go | Add OpenShift validation hook |
| pkg/controller/provider/model/vsphere/model.go | CustomFieldDef PK + disk bus addressing |
| pkg/controller/provider/model/vsphere/doc.go | Register CustomFieldDef model |
| pkg/controller/provider/controller.go | Settings flattening + client embedding |
| pkg/controller/provider/container/vsphere/watch.go | Settings flattening (search interval) |
| pkg/controller/provider/container/ovirt/watch.go | Settings flattening (search interval) |
| pkg/controller/provider/container/ovfbase/watch.go | Settings flattening (search interval) |
| pkg/controller/provider/container/ovfbase/resource.go | Fix ApplyTo field assignments |
| pkg/controller/provider/container/openstack/watch.go | Settings flattening (search interval) |
| pkg/controller/provider/container/openstack/resource.go | Fix time equality |
| pkg/controller/provider/container/nutanix/storage_api.go | Remove redundant prism ensure |
| pkg/controller/provider/container/nutanix/prism.go | Probe prism mode via web client |
| pkg/controller/provider/container/nutanix/prism_test.go | Update caching test to connect() |
| pkg/controller/provider/container/nutanix/image_api.go | listAllV3 call signature update |
| pkg/controller/provider/container/nutanix/decode.go | Remove moved helpers/types |
| pkg/controller/provider/container/nutanix/decode_test.go | Use shared decode structs/helpers |
| pkg/controller/provider/container/nutanix/collector.go | Ensure connect() before collect |
| pkg/controller/provider/container/nutanix/collector_test.go | Pre-connect client in tests |
| pkg/controller/provider/container/hyperv/watch.go | Settings flattening (search interval) |
| pkg/controller/provider/container/hyperv/model.go | Preserve DB fields in LightMode |
| pkg/controller/plan/vm_name_handler.go | Use embedded client methods |
| pkg/controller/plan/util/utils.go | Fix boolean logic readability |
| pkg/controller/plan/util/ovirt.go | Fix ID usage |
| pkg/controller/plan/ssh.go | Plan ref struct refactor |
| pkg/controller/plan/predicate.go | WatchManager embedding refactor |
| pkg/controller/plan/migrator/ocp/live_test.go | Builder struct refactor |
| pkg/controller/plan/migrator/base/migrator.go | Context → embedded plan/source refactor |
| pkg/controller/plan/kubevirt_test.go | Settings flattening test updates |
| pkg/controller/plan/hook_test.go | Settings flattening test updates |
| pkg/controller/plan/controller.go | Settings flattening + condition list access |
| pkg/controller/plan/controller_test.go | Tests updated for condition list changes |
| pkg/controller/plan/context/migration.go | Plan ref struct refactor |
| pkg/controller/plan/adapter/vsphere/inspectionparser.go | Normalize XML unmarshal error |
| pkg/controller/plan/adapter/vsphere/destinationclient.go | Use embedded destination client methods |
| pkg/controller/plan/adapter/vsphere/destinationclient_test.go | Update tests for embedded methods |
| pkg/controller/plan/adapter/ovirt/validator.go | Add ExcludedDisks no-op + settings flatten |
| pkg/controller/plan/adapter/ovirt/destinationclient.go | Use embedded destination client methods |
| pkg/controller/plan/adapter/ovirt/destinationclient_test.go | Update tests for embedded methods |
| pkg/controller/plan/adapter/ovirt/client.go | Settings flattening + log fix |
| pkg/controller/plan/adapter/ovfbase/validator.go | Add ExcludedDisks no-op + refactor |
| pkg/controller/plan/adapter/ovfbase/builder.go | Annotations embedding + DV helper no-ops |
| pkg/controller/plan/adapter/openstack/validator.go | Add ExcludedDisks no-op + refactor |
| pkg/controller/plan/adapter/openstack/destionationclient_test.go | Update tests for embedded methods |
| pkg/controller/plan/adapter/openstack/destinationclient.go | Use embedded destination client methods |
| pkg/controller/plan/adapter/openstack/client.go | Lint suppression + VMStatus field refactor |
| pkg/controller/plan/adapter/nutanix/validator.go | Add ExcludedDisks no-op |
| pkg/controller/plan/adapter/nutanix/image_v4_test.go | Add redirect token validation tests |
| pkg/controller/plan/adapter/hyperv/validator.go | Add ExcludedDisks no-op + refactor |
| pkg/controller/plan/adapter/hyperv/hyperv_suite_test.go | Add Ginkgo suite bootstrap |
| pkg/controller/plan/adapter/hyperv/client.go | Cluster power-off timeout handling |
| pkg/controller/plan/adapter/converter.go | Use embedded destination client methods |
| pkg/controller/plan/adapter/converter_test.go | Update tests for embedded methods |
| pkg/controller/plan/adapter/base/mac_conflicts.go | Flatten embedded VM fields usage |
| pkg/controller/plan/adapter/base/doc.go | Extend Builder/Validator interfaces |
| pkg/controller/ova/builder.go | Settings flattening for OVA |
| pkg/controller/migration/controller.go | Use embedded client methods |
| pkg/controller/map/storage/validation.go | Map provider ref struct refactor |
| pkg/controller/map/storage/predicate.go | WatchManager embedding refactor |
| pkg/controller/map/network/validation.go | Add networkIPMode + validation condition |
| pkg/controller/map/network/predicate.go | WatchManager embedding refactor |
| pkg/controller/hyperv/builder.go | Settings flattening for HyperV |
| pkg/controller/host/validation.go | Host ref struct refactor |
| pkg/controller/host/predicate.go | WatchManager embedding refactor |
| pkg/controller/conversion/pipeline.go | Ignore response body close errors |
| pkg/controller/conversion/context/doc.go | Settings flattening for images |
| pkg/controller/conversion/builder.go | Settings flattening + feature flags |
| pkg/controller/controller.go | Settings role-check refactor |
| pkg/controller/base/controller.go | Use embedded event method + ignore Close |
| pkg/apis/forklift/v1beta1/plan/zz_generated.deepcopy.go | DeepCopy for ExcludeDisks |
| pkg/apis/forklift/v1beta1/plan/vm.go | Add excludeDisks field |
| pkg/apis/forklift/v1beta1/plan.go | CDI routing for excludeDisks + embeds |
| pkg/apis/forklift/v1beta1/plan_transfer_test.go | Add transfer-path test for excludeDisks |
| pkg/apis/forklift/v1beta1/mapping.go | Add networkIPMode to pairs |
| operator/roles/forkliftcontroller/templates/ui-plugin/deployment-ui-plugin.yml.j2 | Runtime IPv6-aware nginx listen |
| operator/roles/forkliftcontroller/templates/ui-plugin/configmap-ui-plugin.yml.j2 | nginx listen placeholder |
| operator/config/crd/bases/forklift.konveyor.io_plans.yaml | CRD schema for excludeDisks |
| operator/config/crd/bases/forklift.konveyor.io_networkmaps.yaml | CRD schema for networkIPMode |
| operator/config/crd/bases/forklift.konveyor.io_migrations.yaml | CRD schema for excludeDisks |
| operator/.upstream_manifests | Sync manifests for new fields |
| operator/.downstream_manifests | Sync manifests for new fields |
| Makefile | Update golangci-lint module/version |
| go.sum | Dependency checksum updates |
| go.mod | Update vm-migration-detective version |
| docs/compatibility/vm-fields.md | Document excludeDisks field |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/settings/settings.go | Sync settings flattening (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/settings/migration.go | Sync settings flattening (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/lib/util/util.go | Sync Close() ignore (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/lib/util/sshutils.go | Sync defer close (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/lib/itinerary/simple.go | Sync itinerary refactor (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan/zz_generated.deepcopy.go | Sync ExcludeDisks deepcopy (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan/vm.go | Sync ExcludeDisks field (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan.go | Sync CDI routing (vendor) |
| cmd/vsphere-copy-offload-populator/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/mapping.go | Sync networkIPMode field (vendor) |
| cmd/virt-v2v/entrypoint.go | Add NFC plugin symlink creation |
| cmd/virt-v2v-monitor/virt-v2v-monitor.go | Ignore stdout write errors |
| cmd/ovirt-populator/ovirt-populator.go | Ignore file close error |
| cmd/openstack-populator/openstack-populator.go | Ignore Close() errors in defers |
| cmd/openstack-populator/openstack-populator_test.go | Test env + io write cleanup |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/util/flags/provider_type.go | Add Nutanix provider type |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/patch/provider/patch.go | Patch Nutanix settings/credentials |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/patch/plan/patch.go | Add excludeDisks planvm patch support |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/get/inventory/vms.go | Allow Nutanix VM inventory |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/get/inventory/storage.go | Nutanix storagecontainers endpoint |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/get/inventory/hosts.go | Allow Nutanix host inventory |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/get/inventory/disks.go | Use GetDisks for OVA |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/get/inventory/clusters.go | Add Hyper-V/Nutanix cluster output |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/describe/plan/describe.go | Display excludeDisks in describe |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/describe/mapping/describe.go | Show networkIPMode column |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/provider/providerutil/options.go | Add Settings + Nutanix options |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/provider/generic/generic.go | Apply ProviderSpec.Settings on create |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/provider/create.go | Add Nutanix provider create support |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/plan/storage/mapper/nutanix/mapper.go | New Nutanix storage mapper |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/plan/storage/factory.go | Wire Nutanix storage components |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/plan/network/mapper/nutanix/mapper.go | New Nutanix network mapper |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/plan/network/factory.go | Wire Nutanix network components |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/mapping/storage_helpers.go | Resolve Nutanix storage IDs |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/pkg/cmd/create/mapping/network_helpers.go | Allow Nutanix network resolution |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/patch/provider.go | Add Nutanix patch flags |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/patch/plan.go | Add exclude-disks patch flag |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/patch/mapping.go | Document networkIPMode syntax |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/get/inventory.go | Expand inventory commands/types |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/get/inventory_vsphere.go | Remove resource-pool command |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/get/inventory_ovirt_vsphere.go | Update cluster cmd docs |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/cutover/plan.go | Fix examples to --vm |
| cmd/kubectl-mtv/vendor/github.com/yaacov/kubectl-mtv/cmd/create/mapping.go | Document networkIPMode syntax |
| cmd/kubectl-mtv/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/vsphere_xcopy_volumepopulator.go | Add xcopy status fields (vendor) |
| cmd/kubectl-mtv/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/provider.go | Add Nutanix provider constants (vendor) |
| cmd/kubectl-mtv/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan/zz_generated.deepcopy.go | Sync ExcludeDisks deepcopy (vendor) |
| cmd/kubectl-mtv/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan/vm.go | Sync ExcludeDisks field (vendor) |
| cmd/kubectl-mtv/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/plan.go | Sync CDI routing (vendor) |
| cmd/kubectl-mtv/vendor/github.com/kubev2v/forklift/pkg/apis/forklift/v1beta1/mapping.go | Sync networkIPMode field (vendor) |
| cmd/kubectl-mtv/go.sum | Dependency checksum updates (kubectl-mtv) |
| cmd/kubectl-mtv/go.mod | Bump kubectl-mtv dependency |
| cmd/hyperv-provider-server/main.go | Ignore fmt.Fprintln error |
| cmd/forklift-controller/main.go | Settings flattening for metrics/profiler |
| .cursor/skills/minimal-changes/SKILL.md | Add Cursor skill documentation |
Review details
Suppressed comments (3)
pkg/controller/provider/web/base/client.go:226
reflect.Pointeris not a validreflect.Kindconstant; usereflect.Ptrfor pointer kinds.
pkg/controller/provider/web/base/client.go:263reflect.Pointeris not a validreflect.Kindconstant; usereflect.Ptrfor pointer kinds.
pkg/controller/plan/controller_test.go:709- This helper iterates
plan.Status.Listbut then indexesplan.Status.Conditions.List[i], which is inconsistent and will either not compile or will backdate the wrong condition list. Use the same list for both the check and the update.
- Files reviewed: 151/283 changed files
- Comments generated: 9
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if _, err := os.Stat(config.NfcPlugin); err == nil { | ||
| err = os.Symlink(config.NfcPlugin, config.NfcPluginBuiltin) | ||
| if err != nil { | ||
| fmt.Println("Error creating nfc plugin link ", err) | ||
| os.Exit(1) | ||
| } | ||
| } |
| lv := reflect.ValueOf(resource) | ||
| switch lv.Kind() { | ||
| case reflect.Ptr: | ||
| case reflect.Pointer: |
| @@ -23,7 +23,7 @@ func (r *Catalog) add(object interface{}) (kind uint16) { | |||
| defer r.Unlock() | |||
| ot := reflect.TypeOf(object) | |||
| ov := reflect.ValueOf(object) | |||
| if reflect.TypeOf(object).Kind() == reflect.Ptr { | |||
| if reflect.TypeOf(object).Kind() == reflect.Pointer { | |||
| @@ -369,7 +369,7 @@ func (f *Field) Incremented() bool { | |||
| func (f *Field) AsValue(object interface{}) (value interface{}, err error) { | |||
| val := reflect.ValueOf(object) | |||
| switch val.Kind() { | |||
| case reflect.Ptr: | |||
| case reflect.Pointer: | |||
| @@ -112,7 +112,7 @@ func (r *Definition) IsKind(kind string) bool { | |||
| // Get the table name for the model. | |||
| func (r Definition) kind(model interface{}) string { | |||
| mt := reflect.TypeOf(model) | |||
| if mt.Kind() == reflect.Ptr { | |||
| if mt.Kind() == reflect.Pointer { | |||
| @@ -43,7 +43,7 @@ type Page struct { | |||
| func (p *Page) Slice(collection interface{}) { | |||
| v := reflect.ValueOf(collection) | |||
| switch v.Kind() { | |||
| case reflect.Ptr: | |||
| case reflect.Pointer: | |||
| @@ -488,7 +490,7 @@ func (t Table) List(list interface{}, options ListOptions) (err error) { | |||
| lt := reflect.TypeOf(list) | |||
| lv := reflect.ValueOf(list) | |||
| switch lt.Kind() { | |||
| case reflect.Ptr: | |||
| case reflect.Pointer: | |||
| @@ -438,7 +438,7 @@ func (r *WatchReader) clone(in interface{}) (out interface{}) { | |||
| mt := reflect.TypeOf(in) | |||
| mv := reflect.ValueOf(in) | |||
| switch mt.Kind() { | |||
| case reflect.Ptr: | |||
| case reflect.Pointer: | |||
| @@ -88,7 +88,7 @@ func (r *EventMapper) findRefs(object interface{}) []Target { | |||
| list := []Target{} | |||
| rt := reflect.TypeOf(object) | |||
| rv := reflect.ValueOf(object) | |||
| if rt.Kind() == reflect.Ptr { | |||
| if rt.Kind() == reflect.Pointer { | |||
No description provided.