Repository navigation
Float the base images and update packages at build time - #1
Merged
Merged
Conversation
The shipped oc comes from the 4.18 must-gather image, which is no longer rebuilt; take it from 4.22 instead. The runtime base now names its floating tag explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
A floating base only helps once the registry rebuilds it; updating at build time also picks up errata released since. The image runs as root, so no ownership needs restoring afterwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
The update layer was served from the build cache whenever the base image was unchanged, so the image could ship updates days old. The Makefile now passes a per-build BUILD_DATE, declared ahead of the update so it re-runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The build must pull refreshed mutable base tags and use BUILD_DATE in the package-update instruction to invalidate its cache.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the image build to use newer OpenShift tooling and refresh runtime packages.
Changes:
- Uses
origin-must-gather:4.22andubi9-minimal:latest. - Adds build-time package updates and a
BUILD_DATEargument. - Updates the Makefile-driven image build.
| File | Summary |
|---|---|
Makefile |
Passes BUILD_DATE; does not force pulling mutable base tags. |
build/Dockerfile |
Updates base images and packages; BUILD_DATE is not used to invalidate the update layer. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+10
| ARG BUILD_DATE=unknown | ||
| RUN microdnf -y update && \ | ||
| microdnf -y install rsync tar gzip jq findutils && \ | ||
| microdnf -y clean all |
anthonytwh
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the image up to date and keeps it there.
ocnow comes fromorigin-must-gather:4.22. The 4.18 image it came from has not been rebuilt since August 2025.ubi9-minimal:latest), and its packages are updated at build time, so the image picks up errata released since the base was last rebuilt.BUILD_DATE, declared ahead of the update so it re-runs.Only
build/Dockerfile, which the Makefile builds, and theMakefilechange;build/Dockerfile-downstreamis untouched.Verification
oc(4.22) andgatherrun, and the collection tools are present.BUILD_DATEtwice leaves the update cached; a new value makes it re-run.🤖 Generated with Claude Code