Repository navigation
Declare a console pluginAPI floor of 4.22 - #7
Merged
Merged
Conversation
This build uses the SDK 4.22 entry callback, which consoles below 4.22 cannot load. A floor makes them reject the plugin loudly instead of loading nothing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Alex O'Regan <alex.oregan@tigera.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Links
release-2.12line (consoles up to 4.21): Declare a console pluginAPI floor of 4.15 (release-2.12) #3📝 Description
Declares which consoles this build supports, so an unsupported console rejects it visibly instead of loading nothing.
This branch builds the plugin for OpenShift consoles 4.22 and later: it uses the 4.22 console SDK, whose entry script only 4.22+ consoles can load. But
plugin-metadata.tsdeclared'@console/pluginAPI': '*', which tells every console the plugin is compatible with it. A 4.21-or-older console accepts it, then shows no Migration pages or navigation and reports no error. With a floor of>=4.22.0-0, those consoles refuse the plugin up front.This is the change shipped on
rel/v3.24.0-2-ocp422, and this PR's commit is the one already onrel/v3.24.0-3-ocp422. Landing it here means later release branches cut frommaincarry it without a per-release pick.🎥 Demo
Built from this branch with
VERSION=2.11.0and run locally. The servedplugin-manifest.jsondeclares the floor, and the entry script uses the 4.22 loader:On
mainwithout this change, the manifest serves{"@console/pluginAPI": "*"}.📝 CC://
🤖 Generated with Claude Code