fix: copyless net driver #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
… copies Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
ytakano
reviewed
Jan 14, 2025
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Koichi98
commented
Jan 14, 2025
Signed-off-by: Koichi Imai <[email protected]>
ytakano
reviewed
Feb 18, 2025
| let read_buf: DMAPool<[u8; PAGESIZE]> = | ||
| DMAPool::new(numa_id, 1).ok_or(IgbDriverErr::DMAPool)?; | ||
| let buf_phy_addr = read_buf.get_phy_addr().as_usize(); | ||
| desc.buf = buf_phy_addr as u64; |
There was a problem hiding this comment.
RX descriptors should be reinitialized in rx_fill(), which is a function for setting up RX descriptors.
| let read_buf: DMAPool<[u8; PAGESIZE]> = | ||
| DMAPool::new(numa_id, 1).ok_or(IxgbeDriverErr::DMAPool)?; | ||
| let buf_phy_addr = read_buf.get_phy_addr().as_usize(); | ||
| desc.read.pkt_addr = buf_phy_addr as u64; |
There was a problem hiding this comment.
Reinitialize RX descriptors in rx_fill().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is one of a series of PRs that consolidates previous network improvement work. In this PR specifically, it eliminates copying when passing from the network driver to if_net.
While there are currently three implemented network device drivers - Ixgbe, Igb, and Genet - this PR does not include support for Genet. This will be tracked as an issue #256. This limitation is also documented in the source code comments.
Related links
Issue #269
How was this PR tested?
Notes for reviewers