Optionally skip tests requiring 'mockr'

[MichaelChirico]

It would be simpler to add the skip() inside the helper:

googledrive/tests/testthat/helper.R

Lines 16 to 18 in b87d89e

	with_mock <- function(..., .parent = parent.frame()) {
	mockr::with_mock(..., .parent = .parent, .env = "googledrive")
	}

But the tests would have to be rewritten a bit, e.g.

googledrive/tests/testthat/test-drive_get_path.R

Lines 68 to 74 in b87d89e

	with_mock(
	root_id = function() "",
	{
	out <- resolve_paths(as_dribble(x), ancestors)
	}
	)
	expect_equal(out$path, "e")

Would probably become:

with_mock(
  root_id = function() "",
  expect_equal(resolve_paths(as_dribble(x), ancestors)$path, "e")
)

That format of test looks more natural to me anyway, but filing as is now pending feedback.

[jennybc]

I've been removing mockr dependencies in favor of testthat::local_mocked_bindings(). Apparently I just haven't done so here yet. So I'm not going to take a change that touches this stuff in any other way; it's not worth fiddling with it.

[MichaelChirico]

Makes sense! I'll leave this open for now in case it serves as a reminder, but feel free to close at any time.