Polishes triggered by revdep failures #6506
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also snuck in another tiny issue I ran into |
teunbrand
changed the title
|
When we use |
13 tasks
teunbrand
commented
Jun 23, 2025
| @@ -317,13 +317,13 @@ S7::method(gtable_ggplot, class_ggplot_built) <- function(data) { | |||
| # TODO: the S3 generic should be phased out once S7 is adopted more widely | |||
| #' @rdname gtable_ggplot | |||
| #' @export | |||
| ggplot_gtable <- function(plot) { | |||
| ggplot_gtable <- function(data) { | |||
There was a problem hiding this comment.
The argument was data before, which I changed to plot because it felt more descriptive. However, this got us into trouble with S3 method/generic consistency.
Comment on lines
+1002
to
+1003
| parent_props <- if (S7::S7_inherits(e2)) S7::props(e2) else unclass(e2) | ||
|
|
There was a problem hiding this comment.
This is so that parent_props$name works, regardless of S3/S7
…d/ggplot2 into revdep_deprecated_theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INITIALLY: Fix revdep failure: don't extract <element_blank>@hjust
This affects only 2 packages (smallsets and utile.visuals), but it is our faux pas.
Essentially, because
element_blankdoes not have thehjustproperty, trying to extract it will error.In this PR, we are more careful in trying to extract this property.