Skip to content

Conversation

topepo
Copy link
Member

@topepo topepo commented Oct 17, 2025

Closes #914

Loooong awaited

@topepo topepo requested a review from EmilHvitfeldt October 17, 2025 20:39
@topepo topepo marked this pull request as ready for review October 17, 2025 20:39
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice improvement!

what is the rational from changing the default from 5 to 100?

@topepo
Copy link
Member Author

topepo commented Oct 18, 2025

what is the rational from changing the default from 5 to 100?

There really is no right answer.

5MB is objectively too low. 100MB is subjectively just right (based on my prior).

Recommendations are welcome

@EmilHvitfeldt
Copy link
Member

I don't have any further recommendations, airing in the higher side properly gives less complaints

@topepo topepo merged commit 9c75bb2 into main Oct 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a check_workflow_size argument to the control functions

2 participants