Skip to content

Fix glmnet penalty check #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Fix glmnet penalty check #1262

merged 3 commits into from
Mar 10, 2025

Conversation

topepo
Copy link
Member

@topepo topepo commented Mar 10, 2025

Closes #1261

Tests forthcoming to extratests

@topepo
Copy link
Member Author

topepo commented Mar 10, 2025

Dev reticulate was failing on windows/R rel-4 (added in #1071) so moved to the CRAN version.

@topepo topepo marked this pull request as ready for review March 10, 2025 17:48
@topepo topepo merged commit 7b03697 into main Mar 10, 2025
10 checks passed
@topepo topepo deleted the penalty-check branch March 10, 2025 17:52
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong penalty checking in get_glmnet_coefs()
1 participant