Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VERSION_SHA to be specified directly (UPLOAD-1441) #1675

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

darinkrauss
Copy link
Contributor

This allows using the Dockerfile without requiring the .git directory (if, for example, the .git directory was specified in the .dockerignore file).

@gniezen
Copy link
Member

gniezen commented Feb 3, 2025

@darinkrauss Is there a Jira ticket that we can link this PR to?

@darinkrauss
Copy link
Contributor Author

@gniezen There is now. 😄 https://tidepool.atlassian.net/browse/UPLOAD-1441

@gniezen
Copy link
Member

gniezen commented Feb 11, 2025

LGTM, but I'll let @krystophv approve the PR as I haven't been working with the Docker stuff lately. Do we need testing for this, or can we close out the ticket as "it will be implicitly be tested as part of the next release candidate" as there aren't any user-facing changes?

@vojtech-cerveny
Copy link
Contributor

Hey, it is not just Dockerfile, right? Can we create build for this to check if this works properly? I don’t expect any issues, but better safe than sorry.

@vojtech-cerveny
Copy link
Contributor

vojtech-cerveny commented Feb 11, 2025

I checked code and I found only one usage of VERSION_SHA, and it is in rollbar.js

And rollbar shows correct commit - it redirects me to the latest commit in this branch. I checked the build on macos.

Copy link
Member

@krystophv krystophv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gniezen gniezen changed the title Allow VERSION_SHA to be specified directly Allow VERSION_SHA to be specified directly (UPLOAD-1441) Feb 18, 2025
@gniezen gniezen merged commit 9df6dcf into develop Feb 20, 2025
4 checks passed
@gniezen gniezen deleted the darin/add-version-sha branch February 20, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants