Skip to content

add staticcheck to ci process #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ewollesen wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add staticcheck to ci process #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,5 @@ services:
script:
- ./build.sh
- make test
- make staticcheck
- ./artifact.sh
8 changes: 8 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ TOOLS_BIN = tools/bin
NPM_BIN = node_modules/.bin

OAPI_CODEGEN = $(TOOLS_BIN)/oapi-codegen
STATICCHECK = $(TOOLS_BIN)/staticcheck
SWAGGER_CLI = $(NPM_BIN)/swagger-cli

NPM_PKG_SPECS = \
Expand Down Expand Up @@ -34,6 +35,9 @@ generate: $(SWAGGER_CLI) $(OAPI_CODEGEN)
test:
GOWORK=off ./test.sh

$(STATICCHECK):
GOBIN=$(shell pwd)/$(TOOLS_BIN) go install honnef.co/go/tools/cmd/staticcheck@2023.1.6

$(OAPI_CODEGEN):
GOBIN=$(shell pwd)/$(TOOLS_BIN) go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@v1.13.4

Expand All @@ -46,3 +50,7 @@ npm-tools:
# has to install all the packages all at the same time. But it saves us from
# having to muck with packages.json.
npm i --no-save --local $(NPM_PKG_SPECS)

.PHONY: staticcheck
staticcheck: $(STATICCHECK)
GOWORK=off $(TOOLS_BIN)/staticcheck --fail none ./...