Skip to content

a few ideas/suggestions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a few ideas/suggestions #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ $ git add .
$ git commit -m "packaged env"
$ git push
```
### [metang] can we make git add/commit part of hub package-env? it's easier to have hub, the push to get the environment checked-in

Copy link
Owner

@tichx tichx Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to let Git do its job since people are more familiar with it?

** During setup compiling, both ```environment.yml``` and ```requirements.txt``` will be generated and packaged into setup.py for simplicity.

EXAMPLE: A simple conda environment file(```environment.yml```):
Expand Down Expand Up @@ -75,7 +77,7 @@ $ python setup.py
> This repository uses Conda environment, do you want to create a new conda environment?
> y/n?: y
> Locating enviornment.yml......
> conda nev create -f environment.yml
> conda env create -f environment.yml
> Setting up....
> 21 packages installed, done.
$ ~(env-name)$ _
Expand All @@ -99,3 +101,4 @@ $ python setup.py
> Taking you to Visual Studio Codespaces....opening browser
> Or alternatively, you can open link: https://codespaces.com/editor/tichx/12323asdf3
```
### i am thinking if we could hide the Azure sign-in part. And only use the github as the account. We could bill customer from github account.
Copy link
Owner

@tichx tichx Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, that might makes a much cleaner solution.