fix(v3.10.31, #411): demo trading wss should only be used for private…

… topics. Fixes #411.
tiagosiebler · Feb 1, 2025 · bbf3a72 · bbf3a72
1 parent 1fa53ba
commit bbf3a72
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/examples/ws-public-v5.ts b/examples/ws-public-v5.ts
@@ -20,6 +20,7 @@ const logger = {
 const wsClient = new WebsocketClient(
   {
     market: 'v5',
+    // demoTrading: true,
   },
   logger,
 );

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bybit-api",
-  "version": "3.10.30",
+  "version": "3.10.31",
   "description": "Complete & robust Node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & strong end to end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/src/util/websocket-util.ts b/src/util/websocket-util.ts
@@ -406,12 +406,7 @@ export function getWsUrl(
     return wsUrl;
   }
 
-  // https://bybit-exchange.github.io/docs/v5/demo
   const isDemoTrading = wsClientOptions.demoTrading;
-  if (isDemoTrading) {
-    return 'wss://stream-demo.bybit.com/v5/private';
-  }
-
   const isTestnet = wsClientOptions.testnet;
   const networkKey = isTestnet ? 'testnet' : 'livenet';
 
@@ -475,6 +470,11 @@ export function getWsUrl(
       return WS_BASE_URL_MAP.contractUSDT.public[networkKey];
     }
     case WS_KEY_MAP.v5Private: {
+      // https://bybit-exchange.github.io/docs/v5/demo
+      if (isDemoTrading) {
+        return 'wss://stream-demo.bybit.com/v5/private';
+      }
+
       return WS_BASE_URL_MAP.v5.private[networkKey];
     }
     case WS_KEY_MAP.v5SpotPublic: {
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,6 +20,7 @@ const logger = { @@
     const wsClient = new WebsocketClient(
       {
         market: 'v5',
+        // demoTrading: true,
       },
       logger,
     );
@@ Expand Down @@